[TESTID-125,126,127,128,129] Saved Query Test Scope #9229

ArgusLi · 2025-01-21T04:22:21Z

Description

Adds a Cypress test suite for Saved Queries Test Scope in the Discover page.

Issues Resolved

Closes #8975, #8977, #8978, #8979, #8980.

Screenshot

saved-queries-1.mp4

saved-queries-2.mp4

saved-queries-3.mp4

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see 2 new test specs saved_queries.spec.js and saved_queries_old_ui.spec.js. Run saved_queries.spec.js if data.savedQueriesNewUI.enabled: true in the OSD config, else run saved_queries_old_ui.spec.js.

Changelog

test: Add cypress integration test for the old and new UI view saved queries.

Signed-off-by: Argus Li <[email protected]>

… old ui and new ui commands Signed-off-by: Argus Li <[email protected]>

Signed-off-by: Argus Li <[email protected]>

angle943 · 2025-01-23T16:49:48Z

@ArgusLi i believe you are having a test failure related to this change: #9150

Signed-off-by: Argus Li <[email protected]>

angle943 · 2025-01-24T17:09:12Z

...search_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries_flyout.spec.js

+  SAVE_AS_NEW_QUERY_SUFFIX,
+  validateSaveAsNewQueryMatchingNameHasError,
+} from '../../../../../utils/apps/query_enhancements/saved_queries';
+


can we rename this file to saved_queries.spec.js

Signed-off-by: Argus Li <[email protected]>

…queries Signed-off-by: Argus Li <[email protected]>

angle943 · 2025-01-24T19:28:11Z

...re_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/saved_queries.spec.js

+
+// This spec assumes data.savedQueriesNewUI.enabled is true.
+export const runSavedQueriesFlyoutUITests = () => {
+  describe('saved queries flyout UI', () => {


lets remove flyout UI

Signed-off-by: Argus Li <[email protected]>

…queries

This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <[email protected]>

ananzh · 2025-01-28T00:30:04Z

Update branch to re-run tests, especially ciGroup 10

Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <[email protected]>

@angle943

* add spec for old ui Signed-off-by: Argus Li <[email protected]> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <[email protected]> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <[email protected]> * Fix DataSource url Signed-off-by: Argus Li <[email protected]> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <[email protected]> * Remove final force. Signed-off-by: Argus Li <[email protected]> * Fix final force. Signed-off-by: Argus Li <[email protected]> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <[email protected]> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <[email protected]> * fix import Signed-off-by: Argus Li <[email protected]> * Load query Signed-off-by: Argus Li <[email protected]> * Complete load query popover and flyout Signed-off-by: Argus Li <[email protected]> * Modularize view and load query popover and flyout Signed-off-by: Argus Li <[email protected]> * Complete valid Saved Queries shown across Visualize Pages Signed-off-by: Argus Li <[email protected]> * Complete Popover delete saved query Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for flyoutbody and delete button. Signed-off-by: Argus Li <[email protected]> * Complete flyout delete saved query Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for saveAsNewQueryCheckbox Signed-off-by: Argus Li <[email protected]> * Complete Flyout Update Saved Query Signed-off-by: Argus Li <[email protected]> * Complete Flyout Save as New Saved Query Signed-off-by: Argus Li <[email protected]> * Complete Popout Save as New Saved Query Signed-off-by: Argus Li <[email protected]> * Changeset file for PR #9229 created/updated * Fix merge Signed-off-by: Argus Li <[email protected]> * Move data-test-subj changes to another PR. Signed-off-by: Argus Li <[email protected]> * Remove savedQueriesNewUI Signed-off-by: Argus Li <[email protected]> * Address all comments. Signed-off-by: Argus Li <[email protected]> * Fix cypress command namespacing. Signed-off-by: Argus Li <[email protected]> * Rename saved queries spec. Signed-off-by: Argus Li <[email protected]> * Remove references to flyout Signed-off-by: Argus Li <[email protected]> * Refactor tests to work with beforeEach and afterEach Signed-off-by: Argus Li <[email protected]> * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <[email protected]> * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> (cherry picked from commit 969114f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@angle943

* add spec for old ui * Add comment about cleaning up saved queries * Add data-test-subj for save query new ui * Add data-test-subj for save query button for new ui * Add data-test-subj for open query button in query management popover * Add new ui spec to test list saved queries * Fix DataSource url * Changeset file for PR #9166 created/updated * Address Justin's comments. * Remove final force. * Fix final force. * Move utils to Suchit's suggested location, fix comments * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands * fix import * Load query * Complete load query popover and flyout * Modularize view and load query popover and flyout * Complete valid Saved Queries shown across Visualize Pages * Complete Popover delete saved query * Add data-test-subj for flyoutbody and delete button. * Complete flyout delete saved query * Add data-test-subj for saveAsNewQueryCheckbox * Complete Flyout Update Saved Query * Complete Flyout Save as New Saved Query * Complete Popout Save as New Saved Query * Changeset file for PR #9229 created/updated * Fix merge * Move data-test-subj changes to another PR. * Remove savedQueriesNewUI * Address all comments. * Fix cypress command namespacing. * Rename saved queries spec. * Remove references to flyout * Refactor tests to work with beforeEach and afterEach * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. --------- (cherry picked from commit 969114f) Signed-off-by: Argus Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]>

@angle943

…ct#9229) * add spec for old ui Signed-off-by: Argus Li <[email protected]> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <[email protected]> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <[email protected]> * Fix DataSource url Signed-off-by: Argus Li <[email protected]> * Changeset file for PR opensearch-project#9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <[email protected]> * Remove final force. Signed-off-by: Argus Li <[email protected]> * Fix final force. Signed-off-by: Argus Li <[email protected]> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <[email protected]> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <[email protected]> * fix import Signed-off-by: Argus Li <[email protected]> * Load query Signed-off-by: Argus Li <[email protected]> * Complete load query popover and flyout Signed-off-by: Argus Li <[email protected]> * Modularize view and load query popover and flyout Signed-off-by: Argus Li <[email protected]> * Complete valid Saved Queries shown across Visualize Pages Signed-off-by: Argus Li <[email protected]> * Complete Popover delete saved query Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for flyoutbody and delete button. Signed-off-by: Argus Li <[email protected]> * Complete flyout delete saved query Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for saveAsNewQueryCheckbox Signed-off-by: Argus Li <[email protected]> * Complete Flyout Update Saved Query Signed-off-by: Argus Li <[email protected]> * Complete Flyout Save as New Saved Query Signed-off-by: Argus Li <[email protected]> * Complete Popout Save as New Saved Query Signed-off-by: Argus Li <[email protected]> * Changeset file for PR opensearch-project#9229 created/updated * Fix merge Signed-off-by: Argus Li <[email protected]> * Move data-test-subj changes to another PR. Signed-off-by: Argus Li <[email protected]> * Remove savedQueriesNewUI Signed-off-by: Argus Li <[email protected]> * Address all comments. Signed-off-by: Argus Li <[email protected]> * Fix cypress command namespacing. Signed-off-by: Argus Li <[email protected]> * Rename saved queries spec. Signed-off-by: Argus Li <[email protected]> * Remove references to flyout Signed-off-by: Argus Li <[email protected]> * Refactor tests to work with beforeEach and afterEach Signed-off-by: Argus Li <[email protected]> * Add force to click when loading saved query. This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <[email protected]> * Fix test issue. Thank you @angle943 for finding a solution. Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Ubuntu <[email protected]>

ArgusLi and others added 27 commits January 8, 2025 21:09

add spec for old ui

02bb7d4

Signed-off-by: Argus Li <[email protected]>

Add comment about cleaning up saved queries

af1352d

Signed-off-by: Argus Li <[email protected]>

Add data-test-subj for save query new ui

d6a713b

Signed-off-by: Argus Li <[email protected]>

Add data-test-subj for save query button for new ui

d6e0785

Signed-off-by: Argus Li <[email protected]>

Add data-test-subj for open query button in query management popover

a15bba2

Signed-off-by: Argus Li <[email protected]>

Add new ui spec to test list saved queries

47fe9a7

Signed-off-by: Argus Li <[email protected]>

Fix DataSource url

49a9352

Signed-off-by: Argus Li <[email protected]>

Merge branch 'main' into testid-124-list-saved-queries

61112c8

Changeset file for PR opensearch-project#9166 created/updated

00b3f60

Address Justin's comments.

edb8f9f

Signed-off-by: Argus Li <[email protected]>

Remove final force.

4ae05a4

Signed-off-by: Argus Li <[email protected]>

Fix final force.

b411dd0

Signed-off-by: Argus Li <[email protected]>

Move utils to Suchit's suggested location, fix comments

eeb0c63

Signed-off-by: Argus Li <[email protected]>

Rename specs, change cypress workflow to use new save query ui, merge…

3c2b2ec

… old ui and new ui commands Signed-off-by: Argus Li <[email protected]>

Merge main

59de88e

Signed-off-by: Argus Li <[email protected]>

fix import

6297366

Signed-off-by: Argus Li <[email protected]>

Load query

bef2e77

Signed-off-by: Argus Li <[email protected]>

Complete load query popover and flyout

2cff1df

Signed-off-by: Argus Li <[email protected]>

Modularize view and load query popover and flyout

2abb5de

Signed-off-by: Argus Li <[email protected]>

Complete valid Saved Queries shown across Visualize Pages

454ac70

Signed-off-by: Argus Li <[email protected]>

Complete Popover delete saved query

4ecaf80

Signed-off-by: Argus Li <[email protected]>

Add data-test-subj for flyoutbody and delete button.

1746c6f

Signed-off-by: Argus Li <[email protected]>

Complete flyout delete saved query

58251de

Signed-off-by: Argus Li <[email protected]>

Add data-test-subj for saveAsNewQueryCheckbox

3bac756

Signed-off-by: Argus Li <[email protected]>

Complete Flyout Update Saved Query

0d98d74

Signed-off-by: Argus Li <[email protected]>

Complete Flyout Save as New Saved Query

51e9ce3

Signed-off-by: Argus Li <[email protected]>

Complete Popout Save as New Saved Query

7061a43

Signed-off-by: Argus Li <[email protected]>

ArgusLi requested review from ananzh, kavilla and AMoo-Miki as code owners January 21, 2025 04:22

Merge branch 'main' into discover-tests-saved-queries

2ff0473

angle943 approved these changes Jan 22, 2025

View reviewed changes

Fix cypress command namespacing.

7e80e64

Signed-off-by: Argus Li <[email protected]>

angle943 reviewed Jan 24, 2025

View reviewed changes

ArgusLi added 2 commits January 24, 2025 09:18

Rename saved queries spec.

2d2c081

Signed-off-by: Argus Li <[email protected]>

Merge remote-tracking branch 'origin/main' into discover-tests-saved-…

57c2ade

…queries Signed-off-by: Argus Li <[email protected]>

angle943 reviewed Jan 24, 2025

View reviewed changes

Remove references to flyout

7e21348

Signed-off-by: Argus Li <[email protected]>

ananzh previously approved these changes Jan 24, 2025

View reviewed changes

LDrago27 added backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative labels Jan 24, 2025

Refactor tests to work with beforeEach and afterEach

d193d64

Signed-off-by: Argus Li <[email protected]>

ArgusLi dismissed ananzh’s stale review via d193d64 January 24, 2025 21:48

ArgusLi added 2 commits January 27, 2025 14:21

Merge remote-tracking branch 'origin/main' into discover-tests-saved-…

f791b6e

…queries

Add force to click when loading saved query.

bc5878a

This removes delay when waiting for toast to disperse. Signed-off-by: Argus Li <[email protected]>

ananzh previously approved these changes Jan 28, 2025

View reviewed changes

Merge branch 'main' into discover-tests-saved-queries

863717d

Fix test issue. Thank you @angle943 for finding a solution.

b162b29

Issue was caused by Cypress being too fast for the date picker to appear. Signed-off-by: Argus Li <[email protected]>

ArgusLi dismissed ananzh’s stale review via b162b29 January 28, 2025 01:53

ananzh approved these changes Jan 28, 2025

View reviewed changes

LDrago27 approved these changes Jan 28, 2025

View reviewed changes

LDrago27 merged commit 969114f into opensearch-project:main Jan 28, 2025
69 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 28, 2025

[Backport 2.x] [TESTID-125,126,127,128,129] Saved Query Test Scope #9286

Merged

ananzh added the v2.19.0 label Jan 28, 2025

ArgusLi mentioned this pull request Jan 28, 2025

[TESTID-125,126,127,128,129] Saved Query Test Scope Add Todo for Workaround #9287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TESTID-125,126,127,128,129] Saved Query Test Scope #9229

[TESTID-125,126,127,128,129] Saved Query Test Scope #9229

ArgusLi commented Jan 21, 2025 •

edited

Loading

angle943 commented Jan 23, 2025

angle943 Jan 24, 2025 •

edited

Loading

angle943 Jan 24, 2025

ananzh commented Jan 28, 2025

[TESTID-125,126,127,128,129] Saved Query Test Scope #9229

[TESTID-125,126,127,128,129] Saved Query Test Scope #9229

Conversation

ArgusLi commented Jan 21, 2025 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

angle943 commented Jan 23, 2025

angle943 Jan 24, 2025 • edited Loading

Choose a reason for hiding this comment

angle943 Jan 24, 2025

Choose a reason for hiding this comment

ananzh commented Jan 28, 2025

ArgusLi commented Jan 21, 2025 •

edited

Loading

angle943 Jan 24, 2025 •

edited

Loading