Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug where metrics were being stored agaisnt the wrong type of galley #3395

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Fixes a bug where metrics were being stored agaisnt the wrong type of galley #3395

merged 8 commits into from
Feb 22, 2023

Conversation

mauromsl
Copy link
Member

  • ArticleAccess.galley_type is now nullable. When None, it indicates an access took place without rendering a galley (i.e. an abstract access)
  • When a new access is recorded form the journal views, it now correctly passes the galley type for storage.
  • A migration has been added to make a best attempt at fixing historic records that did not map to the correct galley type. This is done by exploring if an article had an HTML/XML/Image galley at the time its ArticleAccess records where created.

Closes #3394

@mauromsl mauromsl requested a review from ajrbyers February 14, 2023 18:56
@mauromsl mauromsl merged commit 936b339 into master Feb 22, 2023
@mauromsl mauromsl deleted the 3394-metrics-bugfix branch February 22, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers Awaiting requested review from ajrbyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Article access records are being recorded with the wrong galley type
1 participant
@mauromsl