Ensure unit tests follow redirects

openlibhums · Feb 22, 2023 · 936b339 · 936b339
1 parent 7c8352b
commit 936b339
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/src/metrics/tests.py b/src/metrics/tests.py
@@ -29,17 +29,14 @@ def setUp(self):
             stage="Published",
         )
         clear_cache()
-        self.article_url = reverse(
-            'article_view',
-            kwargs={"identifier_type": "id", "identifier": self.article.pk}
-        )
+        self.article_url = f"/article/id/{self.article.id}"
 
-    @override_settings(URL_CONFIG="domain")
     def test_article_access_when_view_abstract(self):
-        response = self.client.get(
+        self.client.get(
             self.article_url,
             SERVER_NAME=self.journal_one.domain,
             HTTP_USER_AGENT='Chrome/39.0.2171.95 Safari/537.36',
+            follow=True,
         )
         self.assertTrue(
             ArticleAccess.objects.filter(
@@ -50,7 +47,6 @@ def test_article_access_when_view_abstract(self):
             "A 'view' has not been recorded for abstract when no render galley"
         )
 
-    @override_settings(URL_CONFIG="domain")
     def test_article_access_when_view_render_galley(self):
         galley_type = "html"
         galley = helpers.create_galley(
@@ -59,10 +55,11 @@ def test_article_access_when_view_render_galley(self):
         self.article.render_galley = galley
         self.article.save()
 
-        response = self.client.get(
+        self.client.get(
             self.article_url,
             SERVER_NAME=self.journal_one.domain,
             HTTP_USER_AGENT='Chrome/39.0.2171.95 Safari/537.36',
+            follow=True,
         )
         self.assertTrue(
             ArticleAccess.objects.filter(
@@ -73,18 +70,18 @@ def test_article_access_when_view_render_galley(self):
             "A 'view' has not been recorded for rendered galley"
         )
 
-    @override_settings(URL_CONFIG="domain")
     def test_NO_article_access_when_view_non_render_galley(self):
         galley_type = "pdf"
         galley = helpers.create_galley(
             self.article, type=galley_type, public=True
         )
         self.article.save()
 
-        response = self.client.get(
+        self.client.get(
             self.article_url,
             SERVER_NAME=self.journal_one.domain,
             HTTP_USER_AGENT='Chrome/39.0.2171.95 Safari/537.36',
+            follow=True,
         )
         self.assertFalse(
             ArticleAccess.objects.filter(
@@ -103,21 +100,18 @@ def test_NO_article_access_when_view_non_render_galley(self):
             "A 'view' has not been recorded for abstract when no render galley"
         )
 
-    @override_settings(URL_CONFIG="domain")
     def test_article_access_when_download_galley(self):
         galley_type = "pdf"
         galley = helpers.create_galley(
             self.article, type=galley_type, public=True
         )
 
-        galley_url = reverse(
-            'article_download_galley',
-            kwargs={"article_id": self.article.pk, "galley_id": galley.pk}
-        )
-        response = self.client.get(
+        galley_url = f'/article/{self.article.pk}/galley/{galley.pk}/download/'
+        self.client.get(
             galley_url,
             SERVER_NAME=self.journal_one.domain,
             HTTP_USER_AGENT='Chrome/39.0.2171.95 Safari/537.36',
+            follow=True,
         )
         self.assertTrue(
             ArticleAccess.objects.filter(