Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article access records are being recorded with the wrong galley type #3394

Closed
mauromsl opened this issue Feb 14, 2023 · 0 comments · Fixed by #3395
Closed

Article access records are being recorded with the wrong galley type #3394

mauromsl opened this issue Feb 14, 2023 · 0 comments · Fixed by #3395
Assignees
@mauromsl
Labels
bug Something's not working

Comments

@mauromsl
Copy link
Member

Describe the bug
When a new article access is recorded, sometimes the value is recorded as "view" rather than say "PDF" or "XML".

Janeway version
Janeway v1.4.3

To Reproduce
Steps to reproduce the behavior:

  1. Visit any article page
  2. Find the article access records for that article via the shell
  3. Query only the accesses with type "view"
  4. See that galley types are all recorded as "view"

Expected behavior
When an article access of type "view" is recorded, the galley type should match that article's galley type. When no galley is available, the galley type should be set to None, which can be interpreted as visiting the abstract page.

Additional context
This bug has surfaced due to the default galley type having been set as "view":
https://github.com/BirkbeckCTP/janeway/blob/5d1da6a5d2fc2d1eb9881e7955e987dace41a9e8/src/metrics/logic.py#L217
@mauromsl mauromsl added the bug Something's not working label Feb 14, 2023
@mauromsl mauromsl self-assigned this Feb 14, 2023
mauromsl added a commit that referenced this issue Feb 14, 2023
@mauromsl
#3394: Record correct galley type when storing article access records
e5ab20a
mauromsl added a commit that referenced this issue Feb 14, 2023
@mauromsl
#3394: Ensure article access recorded for downloads
9b95daf
mauromsl added a commit that referenced this issue Feb 14, 2023
@mauromsl
#3394: Storing an access defaults to None when no galley_type provided
1ac7c62
mauromsl added a commit that referenced this issue Feb 14, 2023
@mauromsl
#3394: Fix test helper overriding provided kwargs
258574f
@mauromsl mauromsl mentioned this issue Feb 14, 2023
Merged
mauromsl added a commit that referenced this issue Feb 15, 2023
@mauromsl
#3394: Update tests
c43317b
mauromsl added a commit that referenced this issue Feb 22, 2023
@mauromsl
#3394: Record correct galley type when storing article access records
b90dde2
mauromsl added a commit that referenced this issue Feb 22, 2023
@mauromsl
#3394: Ensure article access recorded for downloads
a10feda
mauromsl added a commit that referenced this issue Feb 22, 2023
@mauromsl
#3394: Storing an access defaults to None when no galley_type provided
6928bee
mauromsl added a commit that referenced this issue Feb 22, 2023
@mauromsl
#3394: Fix test helper overriding provided kwargs
584d332
mauromsl added a commit that referenced this issue Feb 22, 2023
@mauromsl
#3394: Update tests
7c8352b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauromsl mauromsl

Labels
bug Something's not working
Projects
No open projects
v1.4.4 Apollo
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a bug where metrics were being stored agaisnt the wrong type of galley openlibhums/janeway
1 participant
@mauromsl