Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Interest interface doesn't stop users from registering an empty string as an interest #4504

Open
mauromsl opened this issue Nov 21, 2024 · 0 comments
Open

Review Interest interface doesn't stop users from registering an empty string as an interest #4504

mauromsl opened this issue Nov 21, 2024 · 0 comments
Assignees
@mauromsl
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development.
Milestone
v1.7.x

Comments

@mauromsl
Copy link
Member

Describe the bug
On one of our production installations, we found a server error that was raised from multiple entries existing for the empty string.

The first problem was that an empty string can end up in the list. The second, is that there are no constraints in the database to guard against duplicate Interests from being inserted.

Janeway version
v1.7.2
@mauromsl mauromsl added the bug Something's not working label Nov 21, 2024
@mauromsl mauromsl added this to the v1.7.x milestone Nov 21, 2024
@mauromsl mauromsl added the dev-ready This issue has been refined and is ready for development. label Nov 21, 2024
@mauromsl mauromsl self-assigned this Nov 21, 2024
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
fix: Avoid users linked to empty string as interest #4504
ffba349
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
refactor: clear stale user interests #4504
783f7cf
@mauromsl mauromsl mentioned this issue Nov 28, 2024
Merged
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
fix: Avoid users linked to empty string as interest #4504
13464ab
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
refactor: clear stale user interests #4504
72ade13
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
chore: Migration for clearing empty interests #4504
7ab040e
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
fix: Avoid users linked to empty string as interest #4504
8cf7015
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
refactor: clear stale user interests #4504
91d558e
mauromsl added a commit that referenced this issue Nov 28, 2024
@mauromsl
chore: Migration for clearing empty interests #4504
d742218
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
fix: Avoid users linked to empty string as interest #4504
4ebef38
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
refactor: clear stale user interests #4504
d142701
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
chore: Migration for clearing empty interests #4504
8a456db
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
fix: Avoid users linked to empty string as interest #4504
b799f46
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
refactor: clear stale user interests #4504
9237b82
mauromsl added a commit that referenced this issue Feb 12, 2025
@mauromsl
chore: Migration for clearing empty interests #4504
0272afe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauromsl mauromsl

Labels
bug Something's not working dev-ready This issue has been refined and is ready for development.
Projects
None yet
Milestone
v1.7.x
Development

No branches or pull requests
1 participant
@mauromsl