fix: Avoid users linked to empty string as interest #4504

openlibhums · Nov 28, 2024 · 13464ab · 13464ab
1 parent c915251
commit 13464ab
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/core/forms/forms.py b/src/core/forms/forms.py
@@ -219,8 +219,11 @@ def save(self, commit=True):
 
         posted_interests = self.cleaned_data['interests'].split(',')
         for interest in posted_interests:
-            new_interest, c = models.Interest.objects.get_or_create(name=interest)
-            user.interest.add(new_interest)
+            if interest:
+                new_interest, _ = models.Interest.objects.get_or_create(
+                    name=interest,
+                )
+                user.interest.add(new_interest)
 
         for interest in user.interest.all():
             if interest.name not in posted_interests:

diff --git a/src/review/logic.py b/src/review/logic.py
@@ -850,8 +850,11 @@ def process_reviewer_csv(path, request, article, form):
                 review_interests = []
 
             for term in review_interests:
-                interest, _ = core_models.Interest.objects.get_or_create(name=term)
-                reviewer.interest.add(interest)
+                if term:
+                    interest, _ = core_models.Interest.objects.get_or_create(
+                        name=term,
+                    )
+                    reviewer.interest.add(interest)
 
             # Add the reviewer role
             reviewer.add_account_role('reviewer', request.journal)