Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue where users could be link to an empty Review Interest #4515

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fixed an issue where users could be link to an empty Review Interest #4515

merged 3 commits into from
Nov 28, 2024

Conversation

mauromsl
Copy link
Member

closes #4504

@mauromsl mauromsl requested a review from ajrbyers November 28, 2024 09:45
@mauromsl mauromsl added this to the v1.7.x milestone Nov 28, 2024
@mauromsl mauromsl requested a review from StephDriver November 28, 2024 09:58
StephDriver
StephDriver approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fine, but does leave existing empty string and/or duplicate interests in the data, probably should tidy those up.

@StephDriver StephDriver assigned mauromsl and unassigned StephDriver Nov 28, 2024
@mauromsl mauromsl merged commit d742218 into r-v1.7.x Nov 28, 2024
@mauromsl mauromsl deleted the b-4504-bugfix branch November 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephDriver StephDriver StephDriver approved these changes

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees

@mauromsl mauromsl

Labels
None yet
Projects
None yet
Milestone
v1.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mauromsl @StephDriver @ajrbyers