-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "MUST" wording which requires exemplar to be on-by-default #2414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR with or without the attached, non-blocking suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the explanation/rationale for this change looks reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I think exemplars are a really important feature we should strive to stabilize and enable by default in the near future. Want to reiterate this question:
I'd still like to understand criteria for marking Exemplar stable. Specifically, what more do we need to see, what issues exist in the current specification.
Fixes #2118, which is considered as a blocking issue for metrics SDK spec stable release.
Changes
We've discussed this during the 3/11/2022 metrics issue triage meeting.
The priority is to ship the stable version of the Metrics SDK spec, however the Exemplar part still has many open questions and there are not sufficient prototype from language SIGs. Here are some decisions we've made in order to move the needles:
This PR removed the "exemplar must be on by default" wording, and used "should be turned off by default" instead. This gives the spec certain room, so later we can change it to "may be turned on by default" or "should be turned on by default" without having to bump the major version of the spec.