Skip to content

Commit

Permalink
Remove the "MUST" wording which requires exemplar to be on-by-default (
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang authored Mar 15, 2022
1 parent 660826e commit b1ca0b3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ release.
([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282))
- Clarified wildcard and predicate support in metrics SDK View API.
([#2325](https://github.com/open-telemetry/opentelemetry-specification/pull/2325))
- Changed the Exemplar wording, exemplar should be turned off by default.
([#2414](https://github.com/open-telemetry/opentelemetry-specification/pull/2414))

### Logs

Expand Down
7 changes: 2 additions & 5 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -519,11 +519,8 @@ While the metric data point for the counter would carry the attributes `X` and
A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements
via the `ExemplarFilter` and `ExemplarReservoir` hooks.

A Metric SDK MUST allow `Exemplar` sampling to be disabled. In this instance
the SDK SHOULD not have overhead related to exemplar sampling.

A Metric SDK MUST sample `Exemplar`s only from measurements within the context
of a sampled trace BY DEFAULT.
`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is
off, the SDK MUST NOT have overhead related to exemplar sampling.

A Metric SDK MUST allow exemplar sampling to leverage the configuration of
metric aggregation. For example, Exemplar sampling of histograms should be able
Expand Down

0 comments on commit b1ca0b3

Please sign in to comment.