Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "MUST" wording which requires exemplar to be on-by-default #2414

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Remove the "MUST" wording which requires exemplar to be on-by-default #2414

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc9cfa0
remove the MUST wording which requires exemplar to be on-by-default
reyang Mar 11, 2022
c4a8abb
update changelog
reyang Mar 11, 2022
7f6b546
Merge branch 'main' into reyang/exemplar
reyang Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,11 +519,8 @@ While the metric data point for the counter would carry the attributes `X` and
A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements
via the `ExemplarFilter` and `ExemplarReservoir` hooks.

A Metric SDK MUST allow `Exemplar` sampling to be disabled. In this instance
the SDK SHOULD not have overhead related to exemplar sampling.

A Metric SDK MUST sample `Exemplar`s only from measurements within the context
of a sampled trace BY DEFAULT.
`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is
jmacd marked this conversation as resolved.
Show resolved Hide resolved
off, the SDK MUST NOT have overhead related to exemplar sampling.

A Metric SDK MUST allow exemplar sampling to leverage the configuration of
metric aggregation. For example, Exemplar sampling of histograms should be able
Expand Down