Rename a few modules #207
Merged
Rename a few modules #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Mar 5, 2020
settings.gradle
Outdated
| include ':instrumentation:aws-sdk-2.2' | ||
| include ':instrumentation:cassandra-3.0' | ||
| include ':instrumentation:cdi-testing' | ||
| include ':instrumentation:class-loader' |
There was a problem hiding this comment.
class-loader or classloader... I'm ok with either, but mentally I generally think of it as one word.
There was a problem hiding this comment.
I agree class-loader looks a bit odd by itself, but it is ClassLoader and not Classloader.
What do you think about java-class-loader?
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classloading ⇒ class-loader
This seems more consistent with other instrumentation like http-url-connection, because it is instrumentation on class loaders.
datastax-cassandra-3.0 ⇒ cassandra-3.0
I don't think there is any ambiguity here. This is the only cassandra driver I'm aware of people using in Java.
reactor-core-3.1 ⇒ reactor-3.1
I don't think there is any ambiguity here.
cdi-1.2 ⇒ cdi-testing
This is consistent with other testing-only modules.
aws-java-sdk-1.11 ⇒ aws-sdk-1.11
aws-java-sdk-2.2 ⇒ aws-sdk-2.2
I don't think there is any ambiguity here (and the artifact name doesn't have java in it).