Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More module / tracer renaming suggestions #163

Closed
28 of 29 tasks
trask opened this issue Feb 13, 2020 · 4 comments
Closed
28 of 29 tasks

More module / tracer renaming suggestions #163

trask opened this issue Feb 13, 2020 · 4 comments

Comments

@trask
Copy link
Member

trask commented Feb 13, 2020

Shorten names where there is no ambiguity

For child modules, use standalone names, so we don't have to concatenate them with parent module to create tracer name (which allows us to simplify tracer names, e.g. servlet-2.3 instead of servlet-request-2.3)

Maybe move common parent modules to "-common" submodule, e.g.

Also, missed this testing module earlier

Still TBD

  • java-class-loader ⇒ java-classloader

A couple more ideas after documenting these on the README:

  • rabbitmq-amqp ⇒ rabbitmq (there is no other client)
  • sparkjava ⇒ spark-web-framework (avoid confusion with Apache Spark)
  • spring-web-mvc ⇒ spring-servlet-mvc
@iNikem
Copy link
Contributor

iNikem commented Jun 26, 2020

spring-web-mvc seems to be like official name, or even just spring-mvc. The other one is then spring-webflux. From https://docs.spring.io/spring/docs/current/spring-framework-reference/web.html#spring-web:

Spring Web MVC is the original web framework built on the Servlet API and has been included in the Spring Framework from the very beginning. The formal name, “Spring Web MVC,” comes from the name of its source module (spring-webmvc), but it is more commonly known as “Spring MVC”.

Parallel to Spring Web MVC, Spring Framework 5.0 introduced a reactive-stack web framework whose name, “Spring WebFlux,” is also based on its source module (spring-webflux).

@trask
Copy link
Member Author

trask commented Jun 26, 2020

👍 to keeping the existing spring-webmvc, which matches the spring artifact name

@iNikem
Copy link
Contributor

iNikem commented Jul 15, 2020

As servlet-common has been taken care of, can we close this issue now, @trask ?

@trask
Copy link
Member Author

trask commented Jul 15, 2020

Yes! 🎉

@trask trask closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants