-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hibernate modules #205
Conversation
Another option is to keep
but remove the "grouping" directory and move these modules directly under instrumentation, then they wouldn't need re-mapping of their project directories. Alternatively, if we are ok with the "grouping" directory pattern, we could add similar grouping directories for |
When I try with:
and put this
I still get the error I was getting before:
I pushed this attempt to https://github.com/trask/opentelemetry-auto-instr-java/tree/rename-hibernate-modules-2 in case anyone with more gradle-fu than me has time to review. |
This will make it possible to have empty "grouping" modules, e.g. instrumentation:hibernate.
I gave the empty grouping module another shot (trying to level up my gradle little by little 😂). It turned out my earlier issues with having empty grouping module was because ":instrumentation" parent is applying "stuff" to all children. First I tried to conditionally apply that "stuff" inside of ":instrumentation" parent gradle file, but that didn't go very well, so I extracted the "stuff" out into a shared gradle file, and applied that inside of each instrumentation, and that worked out pretty good! |
The goal of this PR is for the module names to be usable directly as artifact names when we publish them to maven central.
Existing module paths were:
Initially I tried:
But gradle doesn't like having an empty parent
:instrumentation:hibernate
, so I ended up atand re-mapping their project directories in
settings.gradle
to keep them under a top-levelhibernate
directory.