Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename elasticsearch modules #221

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Rename elasticsearch modules #221

merged 2 commits into from
Mar 10, 2020

Conversation

trask
Copy link
Member

@trask trask commented Mar 9, 2020

The goal of this PR is for the module names to be usable directly as artifact names when we publish them to maven central.

Existing module paths were:

:instrumentation:elasticsearch:rest-5.0
:instrumentation:elasticsearch:rest-6.4
:instrumentation:elasticsearch:transport-2.0
:instrumentation:elasticsearch:transport-5.0
:instrumentation:elasticsearch:transport-5.3
:instrumentation:elasticsearch:transport-6.0
:instrumentation:elasticsearch (this has common code)

New module paths are:

:instrumentation:elasticsearch:elasticsearch-rest-5.0
:instrumentation:elasticsearch:elasticsearch-rest-6.4
:instrumentation:elasticsearch:elasticsearch-transport-2.0
:instrumentation:elasticsearch:elasticsearch-transport-5.0
:instrumentation:elasticsearch:elasticsearch-transport-5.3
:instrumentation:elasticsearch:elasticsearch-transport-6.0
:instrumentation:elasticsearch:elasticsearch-common

@trask trask mentioned this pull request Mar 9, 2020
Closed
29 tasks
@trask trask marked this pull request as ready for review March 10, 2020 00:09
@trask trask merged commit e5b8321 into open-telemetry:master Mar 10, 2020
@trask trask deleted the rename-elasticsearch-modules branch March 10, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@safris safris Awaiting requested review from safris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @tylerbenson