Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a few modules #207

Merged
merged 7 commits into from
Mar 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/** Tracing Request Handler */
public class TracingRequestHandler extends RequestHandler2 {
private static final Tracer TRACER =
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.aws-java-sdk-1.11");
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.aws-sdk-1.11");

private final AwsSdkClientDecorator decorate;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class AwsSdkClientDecorator extends HttpClientDecorator<SdkHttpRequest, S
public static final AwsSdkClientDecorator DECORATE = new AwsSdkClientDecorator();

public static final Tracer TRACER =
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.aws-java-sdk-2.2");
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.aws-sdk-2.2");

static final String COMPONENT_NAME = "java-aws-sdk";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

public class TracingSession implements Session {
private static final Tracer TRACER =
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.datastax-cassandra-3.0");
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.cassandra-3.0");

private final ExecutorService executorService = Executors.newCachedThreadPool();
private final Session session;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apply from: "${rootDir}/gradle/java.gradle"

dependencies {
testCompile project(':instrumentation:classloading')
testCompile project(':instrumentation:java-class-loader')

testCompile group: 'org.jboss.modules', name: 'jboss-modules', version: '1.3.10.Final'
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apply from: "${rootDir}/gradle/java.gradle"

dependencies {
testCompile project(':instrumentation:classloading')
testCompile project(':instrumentation:java-class-loader')

// TODO: we should separate core and Eclipse tests at some point,
// but right now core-specific tests are quite dump and are run with
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.opentelemetry.auto.instrumentation.classloading;
package io.opentelemetry.auto.instrumentation.classloader;

import static io.opentelemetry.auto.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
import static java.util.Collections.singletonMap;
Expand Down Expand Up @@ -47,9 +47,9 @@
* for the classes that we have put in the bootstrap class loader.
*/
@AutoService(Instrumenter.class)
public final class ClassloadingInstrumentation extends Instrumenter.Default {
public ClassloadingInstrumentation() {
super("classloading");
public final class ClassLoaderInstrumentation extends Instrumenter.Default {
public ClassLoaderInstrumentation() {
super("class-loader");
}

@Override
Expand Down Expand Up @@ -81,7 +81,7 @@ public Map<? extends ElementMatcher<? super MethodDescription>, String> transfor
.and(takesArgument(1, named("boolean")))))
.and(isPublic().or(isProtected()))
.and(not(isStatic())),
ClassloadingInstrumentation.class.getName() + "$LoadClassAdvice");
ClassLoaderInstrumentation.class.getName() + "$LoadClassAdvice");
}

public static class LoadClassAdvice {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
import io.opentelemetry.auto.test.AgentTestRunner

class ClassloadingTest extends AgentTestRunner {
class ClassLoadingTest extends AgentTestRunner {
def "delegates to bootstrap class loader for agent classes"() {
setup:
def classLoader = new NonDelegatingURLClassLoader()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ testSets {
}

dependencies {
testCompile project(':instrumentation:classloading')
testCompile project(':instrumentation:java-class-loader')

//This seems to be the earliest version that has org.apache.catalina.loader.WebappClassLoaderBase
//Older versions would require slightly different instrumentation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
public class ReactorCoreDecorator extends BaseDecorator {
public static ReactorCoreDecorator DECORATE = new ReactorCoreDecorator();
public static final Tracer TRACER =
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.reactor-core-3.1");
OpenTelemetry.getTracerFactory().get("io.opentelemetry.auto.reactor-3.1");

@Override
protected String getSpanType() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import static io.opentelemetry.trace.Span.Kind.SERVER

/**
* Unfortunately because we're using an embedded GlassFish instance, we aren't exercising the standard
* OSGi setup that requires {@link io.opentelemetry.auto.instrumentation.classloading.ClassloadingInstrumentation}.
* OSGi setup that requires {@link io.opentelemetry.auto.instrumentation.classloader.ClassloadingInstrumentation}.
*/
// TODO: Figure out a better way to test with OSGi included.
class GlassFishServerTest extends HttpServerTest<GlassFish, Servlet3Decorator> {
Expand Down
8 changes: 4 additions & 4 deletions instrumentation/spring-webflux-5.0/spring-webflux-5.0.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@ testSets {

dependencies {
// We use helpers from this project
main_java8CompileOnly project(':instrumentation:reactor-core-3.1')
main_java8CompileOnly project(':instrumentation:reactor-3.1')
main_java8CompileOnly group: 'org.springframework', name: 'spring-webflux', version: '5.0.0.RELEASE'

// We are using utils class from reactor-core instrumentation.
// We are using utils class from reactor instrumentation.
// TODO: It is unclear why we need to use `compile` here (instead of 'compileOnly')
compile project(':instrumentation:reactor-core-3.1')
compile project(':instrumentation:reactor-3.1')

testCompile project(':instrumentation:java-concurrent')
testCompile project(':instrumentation:trace-annotation')
testCompile project(':instrumentation:netty-4.1')
testCompile project(':instrumentation:reactor-core-3.1')
testCompile project(':instrumentation:reactor-3.1')

testCompile group: 'org.springframework.boot', name: 'spring-boot-starter-webflux', version: '2.0.0.RELEASE'
testCompile group: 'org.springframework.boot', name: 'spring-boot-starter-test', version: '2.0.0.RELEASE'
Expand Down
30 changes: 15 additions & 15 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,12 @@ include ':instrumentation:akka-http-10.0'
include ':instrumentation:apache-httpasyncclient-4.0'
include ':instrumentation:apache-httpclient-3.0'
include ':instrumentation:apache-httpclient-4.0'
include ':instrumentation:aws-java-sdk-1.11'
include ':instrumentation:aws-java-sdk-2.2'
include ':instrumentation:cdi-1.2'
include ':instrumentation:classloading'
include ':instrumentation:classloading:jboss-testing'
include ':instrumentation:classloading:osgi-testing'
include ':instrumentation:classloading:tomcat-testing'
include ':instrumentation:aws-sdk-1.11'
include ':instrumentation:aws-sdk-2.2'
include ':instrumentation:cassandra-3.0'
include ':instrumentation:cdi-testing'
include ':instrumentation:couchbase-2.0'
include ':instrumentation:couchbase-2.6'
include ':instrumentation:datastax-cassandra-3.0'
include ':instrumentation:dropwizard-views-0.7'
include ':instrumentation:dropwizard-testing'
include ':instrumentation:elasticsearch'
Expand All @@ -77,6 +73,16 @@ include ':instrumentation:hibernate:core-4.0'
include ':instrumentation:hibernate:core-4.3'
include ':instrumentation:http-url-connection'
include ':instrumentation:hystrix-1.4'
include ':instrumentation:java-class-loader'
include ':instrumentation:java-class-loader:jboss-testing'
include ':instrumentation:java-class-loader:osgi-testing'
include ':instrumentation:java-class-loader:tomcat-testing'
include ':instrumentation:java-concurrent'
include ':instrumentation:java-concurrent:kotlin-testing'
include ':instrumentation:java-concurrent:scala-testing'
include ':instrumentation:java-concurrent:akka-testing'
include ':instrumentation:java-concurrent:akka-2.5-testing'
include ':instrumentation:java-util-logging-events'
include ':instrumentation:jaxrs-1.0'
include ':instrumentation:jaxrs-2.0'
include ':instrumentation:jaxrs-2.0:jaxrs-2.0-jersey-2.0'
Expand All @@ -86,12 +92,6 @@ include ':instrumentation:jaxrs-client-1.1'
include ':instrumentation:jaxrs-client-2.0'
include ':instrumentation:jaxrs-client-2.0:jaxrs-client-2.0-jersey-2.0'
include ':instrumentation:jaxrs-client-2.0:jaxrs-client-2.0-resteasy-2.0'
include ':instrumentation:java-concurrent'
include ':instrumentation:java-concurrent:kotlin-testing'
include ':instrumentation:java-concurrent:scala-testing'
include ':instrumentation:java-concurrent:akka-testing'
include ':instrumentation:java-concurrent:akka-2.5-testing'
include ':instrumentation:java-util-logging-events'
include ':instrumentation:jdbc'
include ':instrumentation:jedis-1.4'
include ':instrumentation:jedis-3.0'
Expand Down Expand Up @@ -123,7 +123,7 @@ include ':instrumentation:play-ws-2.0'
include ':instrumentation:play-ws-2.1'
include ':instrumentation:rabbitmq-amqp-2.7'
include ':instrumentation:ratpack-1.4'
include ':instrumentation:reactor-core-3.1'
include ':instrumentation:reactor-3.1'
include ':instrumentation:rmi'
include ':instrumentation:rxjava-1.0'
include ':instrumentation:servlet'
Expand Down