[Metrics builder] Move resource creation to the generated code #8555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
metric-builder-resource
branch
15 times, most recently
from
3b3ca32 to
7592d08
Compare
|
@djaglowski @codeboten please let me know what do you think about this approach to #8358 |
dmitryax
force-pushed
the
metric-builder-resource
branch
from
7592d08 to
0de3ef7
Compare
mstumpfx
reviewed
Mar 21, 2022
codeboten
reviewed
Mar 22, 2022
dmitryax
force-pushed
the
metric-builder-resource
branch
from
223c967 to
65e550b
Compare
djaglowski
reviewed
Mar 23, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go
Show resolved
Hide resolved
receiver/rabbitmqreceiver/internal/metadata/generated_metrics_v2.go
Outdated
Show resolved
Hide resolved
dmitryax
force-pushed
the
metric-builder-resource
branch
from
65e550b to
abb36f4
Compare
dmitryax
force-pushed
the
metric-builder-resource
branch
2 times, most recently
from
3806dc6 to
543ffd2
Compare
djaglowski
approved these changes
Mar 23, 2022
This change updates metrics builder to fully control creation of the metrics object. Scraper author don't need to create pdata.Metrics object and pass it to MetricsBuiler.Emit function. This change also moves definition of resource attributes to metadata.yaml which is used to generate attribute helper that can be used in the scraper. 313873
dmitryax
force-pushed
the
metric-builder-resource
branch
from
543ffd2 to
85da9de
Compare
codeboten
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates metrics builder to fully control creation of the
pdata.Metricsobject, scraper author don't need to create and pass it toMetricsBuiler.Emitfunction anymore.This change also moves definition of resource attributes to metadata.yaml which is used to generate attribute helper that can be used in the scraper.
Closes: #8358
Also this is the first PR towards #7301.
The following items will be resolved as follow-up PRs:
wrapBySchemaURLSetterConsumer