Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics builder] Generate whole pdata.Metrics object #8358

Closed
Tracked by #10904
dmitryax opened this issue Mar 9, 2022 · 0 comments · Fixed by #8555
Closed
Tracked by #10904

[Metrics builder] Generate whole pdata.Metrics object #8358

dmitryax opened this issue Mar 9, 2022 · 0 comments · Fixed by #8555

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 9, 2022 •
edited
Loading

NewMetricData method was added in #8255 but we can avoid exposing it and create pdata.Metrics internally by the first call to Record...DataPoint. Emit signature should be changed to:

func (mb *MetricsBuilder) Emit() pdata.Metrics

Originally posted: #8255 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dmitryax