Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics builder] Remove generation of Attribute constants #8842

Closed
Tracked by #10904
dmitryax opened this issue Mar 24, 2022 · 0 comments · Fixed by #9974
Closed
Tracked by #10904

[Metrics builder] Remove generation of Attribute constants #8842

dmitryax opened this issue Mar 24, 2022 · 0 comments · Fixed by #9974

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 24, 2022 •
edited
Loading

After merging #8555, generation of Attributes is not needed anymore.

The only part of attributes that is still needed is attribute enum values. They should be replaced with iota constants which is tracked in #9595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Metrics builder] Remove Attributes struct dmitryax/opentelemetry-collector-contrib
1 participant
@dmitryax