Migrate converter thrift jaeger

[Nabil-Salah]

Description

Remove jaeger model/converter/thrift/jaeger dependency

Link to tracking issue

Resolves #37820

Part of jaegertracing/jaeger#6409

Testing

Documentation

[Nabil-Salah]

PTAL @yurishkuro

[yurishkuro]

I don't see the new functions used anywhere.

[Nabil-Salah]

I don't see the new functions used anywhere.

@yurishkuro
It'll be used in receiver/jaegerreceiver/jaeger_agent_test.go but after the release ( currently can't as they are of different modules )
and also when migrating the cmd/agent

as we planned here: https://docs.google.com/document/d/11ITBz59augUHL40jzgPKzEULUEPKCUwChRDERt7zQAk/edit?usp=drivesdk

[yurishkuro]

Sorry I don't follow - which release are you blocked on?

[Nabil-Salah]

@yurishkuro
currently github.com/open-telemetry/opentelemetry-collector-contrib/ v0.119.0

which doesn't has the migrated jaeger, zipkin converter code so i can't use it now in any place outside of there modules

as opentelemetry-collector-contrib repo made of multiple modules all of different github base link

[yurishkuro]

Whole contrib was just upgraded to latest jaeger 1.66, so you don't have dependencies from that side. And internal dependencies in contrib are all correlated, modules don't depend on different versions of other modules, they use local overrides.

[Nabil-Salah]

PTAL @yurishkuro
I'm back, I started using the imported library the problem was that I couldn't use modules made under the internal folder outside its module

so now in the prev pr #37796 I'll need to make a new pr to move the migrated module outside of internal to use it

[yurishkuro]

is this literally the only file in contrib that depends on this Jaeger module? I don't think it makes sense to migrate in this case, we can probably just refactor the test to not have the dependency.

[yurishkuro]

e.g. this is the only place I see it being used

jexp.EmitBatch(context.Background(), modelToThrift(batch))

i.e. it needs to construct thrift payload to send to the server. We can just load one of the JSON thrift fixtures and parse it in Thrift model.

[Nabil-Salah]

i can do this
but it will also be used when migrating cmd/agent
#37796

[Nabil-Salah]

so what way you suggest going with?

[yurishkuro]

Ah, I see what you mean. Let's proceed here then.