Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jaeger model/converter/thrift/jaeger dependency #37820

Closed
Nabil-Salah opened this issue Feb 11, 2025 · 1 comment · Fixed by #37823
Closed

Remove jaeger model/converter/thrift/jaeger dependency #37820

Nabil-Salah opened this issue Feb 11, 2025 · 1 comment · Fixed by #37823
Labels
needs triage New item requiring triage pkg/translator/jaeger

Comments

@Nabil-Salah
Copy link
Contributor

Component(s)

pkg/translator/jaeger

Describe the issue you're reporting

Component(s)

pkg/translator/jaeger

Describe the issue you're reporting

To prevent circular dependencies between Jaeger and contrib, copy the necessary code and replace the import.
jaegertracing/jaeger#6409
@Nabil-Salah Nabil-Salah added the needs triage New item requiring triage label Feb 11, 2025
This was referenced Feb 11, 2025
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for pkg/translator/jaeger: @open-telemetry/collector-approvers @frzifus. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

djaglowski pushed a commit that referenced this issue Feb 14, 2025
@Nabil-Salah
Migrate converter thrift jaeger (#37823)
54063ce 
#### Description
Remove jaeger model/converter/thrift/jaeger dependency

#### Link to tracking issue
Resolves
#37820

Part of jaegertracing/jaeger#6409

#### Testing

#### Documentation

---------

Signed-off-by: nabil salah <[email protected]>
@github-actions github-actions bot mentioned this issue Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage pkg/translator/jaeger
Projects
None yet
Milestone
No milestone
2 participants
@crobert-1 @Nabil-Salah