Migrate jaeger model/converter/thrift/zipkin

[Nabil-Salah]

Description

Remove jaeger model/converter/thrift/zipkin dependency

Link to tracking issue

Resolves #37795

Part of jaegertracing/jaeger#6409

Testing

Documentation

[Nabil-Salah]

hello @yurishkuro
i tried first with this pr of moving model/converter/thrift/zipkin
is this the right location it should be moved to?

[yurishkuro]

once this is merged may want to book another ticket to implement direct translation zipkin->OTLP, there's no reason why this needs to go through the jaeger model, just an extra overhead.

[Nabil-Salah]

@yurishkuro these lints will require code editing should I edit the code or is there another thing to do?

[yurishkuro]

yes, you can edit the code. The linter in this repo may be slightly different. Also, you need to make fmt the code

[Nabil-Salah]

PTAL @yurishkuro

[Nabil-Salah]

PTAL @yurishkuro
I think it's ready to be merged

[yurishkuro]

@Nabil-Salah looks like you missed one

receiver/zipkinreceiver/trace_receiver_test.go
21:	zipkin2 "github.com/jaegertracing/jaeger/model/converter/thrift/zipkin"

[yurishkuro]

and another

receiver/jaegerreceiver/jaeger_agent_test.go
17:	jaegerconvert "github.com/jaegertracing/jaeger/model/converter/thrift/jaeger"

[Nabil-Salah]

@Nabil-Salah looks like you missed one

oh sorry will open another pr and continue working on this

[yurishkuro]

please link PRs to jaegertracing/jaeger#6409

[Nabil-Salah]

@yurishkuro
I think the problem why I skipped those was because these are of different modules so I will need to wait for a release to use the newly added code

I can attach to head commit I think If you want so but I don't think this is a good way

[Nabil-Salah]

if will wait for the release i think we can go for this

once this is merged may want to book another ticket to implement direct translation zipkin->OTLP, there's no reason why this needs to go through the jaeger model, just an extra overhead.

[yurishkuro]

you are right, converter/thrift/jaeger is a different module, but converter/thrift/zipkin is the same, is it not?

in either case the goal is to break the circular dependencies completely, so we may need to copy converter/thrift/jaeger as well (I think it will be needed for cmd/agent migration).

[yurishkuro]

missed

$ rg jaegertracing/jaeger/model
receiver/zipkinreceiver/trace_receiver_test.go
21:	zipkin2 "github.com/jaegertracing/jaeger/model/converter/thrift/zipkin"

[Nabil-Salah]

yes, I'll make pr for this now