Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jaeger model/converter/thrift/zipkin dependency #37795

Closed
Nabil-Salah opened this issue Feb 9, 2025 · 1 comment · Fixed by #37796 or #37934
Closed

Remove jaeger model/converter/thrift/zipkin dependency #37795

Nabil-Salah opened this issue Feb 9, 2025 · 1 comment · Fixed by #37796 or #37934
Labels
needs triage New item requiring triage pkg/translator/zipkin

Comments

@Nabil-Salah
Copy link
Contributor

Component(s)

pkg/translator/zipkin

Describe the issue you're reporting

To prevent circular dependencies between Jaeger and contrib, copy the necessary code and replace the import. jaegertracing/jaeger#6494
@Nabil-Salah Nabil-Salah added the needs triage New item requiring triage label Feb 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@Nabil-Salah Nabil-Salah mentioned this issue Feb 9, 2025
Merged
@github-actions github-actions bot mentioned this issue Feb 11, 2025
Open
This was referenced Feb 11, 2025
Closed
Merged
songy23 pushed a commit that referenced this issue Feb 17, 2025
@Nabil-Salah
[zipkinreceiver] Remove last dependency on Jaeger (#37934)
989b148 
#### Description

Moved module out of internal
Use thrift zipkin converter

#### Link to tracking issue
Resolves
#37795

Part of jaegertracing/jaeger#6409

#### Testing
`go test`

#### Documentation

---------

Signed-off-by: nabil salah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage New item requiring triage pkg/translator/zipkin
Projects
None yet
Milestone
No milestone
1 participant
@Nabil-Salah