-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all text that might appear in cove-ocds is translated into Spanish #144
Comments
I've taken the list of valdiator functions that we didn't translate for OC4IDS, and broken it down into categories. Unlike for OC4IDS, I've not compared the list to our schemas, because extensions in OCDS can have arbitary JSON schema.
The first category requires nothing to be done. The second category should be fairly easy, as we just need to insert the same translated message every time. (As we already do for these cases.) The third category probably requires us to swap in a modified function in lib-cove, in order to return more information on the validation error object. (As we already do for uniqueness: lib-cove, lib-cove-web.) My next step will be to write some extended test data that uses all the different validators. |
Here's my extended test data, which uses a newly written test extension:
I've got all of these translateable locally now. Here's a screenshot with a "pseudo" translation: Tomorrow I will:
|
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
This breaks pseudo translations, possibly real ones too. open-contracting/cove-ocds#144
on each ValidationError, so that we can replace the message with a translation in cove_ocds. open-contracting/cove-ocds#144
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
This breaks pseudo translations, possibly real ones too. open-contracting/cove-ocds#144
I pushed my work so far, its across 4 different repos, so we have 4 different PRs:
Next steps:
|
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
on each ValidationError, so that we can replace the message with a translation in lib-cove-web. open-contracting/cove-ocds#144
The Spanish translations are now complete. open-contracting/cove-ocds#144
The Spanish translations are now complete. #144
(to pull in changes relating to Spanish translations) #144
(fixes earlier commit by adding the Spanish translations) #144
(fixes earlier commit by adding the Spanish translations) #144
These changes are now live https://standard.open-contracting.org/review/ |
As we did for cove-oc4ids last year open-contracting/cove-oc4ids#59 (so a lot of the work has been done).
Decide whether to translate ocds-show (I would guess probably not, since it's archived).
The text was updated successfully, but these errors were encountered: