-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config gNBs and UPFs #194
feat: config gNBs and UPFs #194
Conversation
Provide sample UPF list file and gNB list file. |
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
f90462c
to
e36af39
Compare
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
9fc9da6
to
8dd0de4
Compare
Signed-off-by: Patricia Reinoso <[email protected]>
@gruyaume these changes do not use the build tag |
I think that's fine, they are not directly related to the ui and they won't break any existing behaviour. |
Signed-off-by: Patricia Reinoso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming this has been tested manually as well
configapi/api_inventory_test.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tests :)
@thakurajayL can we move forward with this PR? |
|
||
type Upf struct { | ||
Hostname string `json:"hostname"` | ||
Port string `json:"port"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO you plan to port as 8805 or some other non standard port? SMF may be using default 8805 port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using port 8805 and we intend to maintain consistency with the SMF by using the same port.
return fmt.Errorf("Failed to create UPF %v: %w", upfHostname, err) | ||
} | ||
if newUpf.Port == "" { | ||
errorMessage := "Post UPF request body is missing port" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to know how UPF port is used and what it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UPF port is specified in the parameters when creating a new network slice.
"upf": {
"upf-name": "upf-external.testpcf.svc.cluster.local",
"upf-port": "8805"
}
We are keeping the UPF parameters consistent with what is asked for network slice creation, even if we use 8805.
Inventory Service
This feature adds endpoints to configure gNBs and UPFs.
gNB
/config/v1/inventory/gnb
inventory/gnb/:gnb-name
inventory/gnb/:gnb-name
UPF
/config/v1/inventory/upf
inventory/gnb/:upf-hostname
inventory/gnb/:upf-hostname
Usage
gNB
Get all gNBs
Add a new gNB.
tac
parameter is mandatory.Remove a gNB.
UPF
Get all UPFs
Add a new UPF.
port
parameter is mandatory.Remove a UPF.
Rationale
Canonical builds its own UI for WebConsole (we call it NMS). The NMS needs to retrieve a list of UPF and gNB to configure Network Slices, these parameters can be dynamically configured. Since the NMS is exported in static files and served by the Webconsole (#191), the NMS needs to retrieve these parameters from a webconsole service.