-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use webui API in NMS #619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gatici
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor things are commented for improvement.
ghislainbourgeois
approved these changes
Jul 31, 2024
patriciareinoso
force-pushed
the
TELCO-1151-use-webui-api
branch
from
August 1, 2024 07:28
e350eef
to
d6728aa
Compare
gatici
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the internal NMS backend and have the client interface query the webui API directly.
Breaking change. It uses new Rock version
1.0.0
pages/
, which correspond to the internal NMS backend.call*Api.tsx
files, which contain the calls to the webui API (subscribers, networks slices and device groups).next.config.js
: it contains the configuration to export the NMS into static files when building. Parameters that are no longer necessary were removed./
to/network-configuration
is placed onapp/page.tsx
DeleteSubscriberButton.tsx
,checkNetworkSliceExists.tsx
This PR depends on the following PRs:
Checklist: