Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add observation for sdcore management relation joined #337

Closed

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Sep 24, 2024

Description

1.4/edge branch uses latest revision of nms image.
While running E2E sdcore-tests sometimes NMS stuck at installing agent status and sdcore-management-relation-changed hook fails.The reason of this failure is charm does not include storage paths of UPF and GNB config. As they are moved to webui which provides endpoints to configure UPF and GNB.
These are the related changes which causes the issue.

As a solution UPF and GNB config paths are removed from the charm.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner September 24, 2024 09:20
src/charm.py Outdated Show resolved Hide resolved
@gatici gatici marked this pull request as draft September 24, 2024 12:02
…s not include them paths for them after this change canonical/sdcore-nms#621.

Signed-off-by: gatici <[email protected]>
@gatici gatici force-pushed the add-observation-for-sdcore-management-relation-joined branch from b87fa46 to 3b78f7d Compare September 24, 2024 12:43
@gatici
Copy link
Contributor Author

gatici commented Sep 24, 2024

This change does not solve the problem as NMS can not start independently using current image https://github.com/canonical/sdcore-nms/blob/main/rockcraft.yaml. The image is designed to run only Webui service. It is not easy to backport NMS- Webui combination to branch v1.4.

@gatici gatici closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants