#1571 - Create vuex module for chat #1854

SebinSong · 2024-02-20T20:55:29Z

The work was done based on the docs here: https://v3.vuex.vuejs.org/guide/modules.html

…eate-vuex-module-for-chat

cypress · 2024-02-20T22:28:03Z

Passing run #1910 ↗︎

0	110	8	0	0

Details:

Merge `f95234b` into `ccbe124`...
Project: group-income	Commit: `c692e6e268 ℹ️`
Status: Passed	Duration: 10:40 💡
Started: Feb 23, 2024 5:12 PM	Ended: Feb 23, 2024 5:23 PM

Review all test suite changes for PR #1854 ↗︎

taoeffect

Nice! I couldn't find any issues... but this is a significant change so I'm going to wait on either @Silver-IT and/or @corrideat for another approval before merging.

taoeffect · 2024-02-21T20:02:59Z

frontend/model/state.js

+    const chatroomState = state.chatroom || {}
    // TODO: need to remove the whole content after we release 0.2.*
-    for (const chatRoomId in state.chatRoomUnread) {
-      if (!state.chatRoomUnread[chatRoomId].messages) {
-        state.chatRoomUnread[chatRoomId].messages = []
+    for (const chatRoomId in chatroomState.chatRoomUnread) {
+      if (!chatroomState.chatRoomUnread[chatRoomId].messages) {
+        chatroomState.chatRoomUnread[chatRoomId].messages = []
      }
-      if (state.chatRoomUnread[chatRoomId].mentions) {
-        state.chatRoomUnread[chatRoomId].mentions.forEach(m => {
-          state.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.TEXT }, m))
+      if (chatroomState.chatRoomUnread[chatRoomId].mentions) {
+        chatroomState.chatRoomUnread[chatRoomId].mentions.forEach(m => {
+          chatroomState.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.TEXT }, m))
        })
-        Vue.delete(state.chatRoomUnread[chatRoomId], 'mentions')
+        Vue.delete(chatroomState.chatRoomUnread[chatRoomId], 'mentions')
      }
-      if (state.chatRoomUnread[chatRoomId].others) {
-        state.chatRoomUnread[chatRoomId].others.forEach(o => {
-          state.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.INTERACTIVE }, o))
+      if (chatroomState.chatRoomUnread[chatRoomId].others) {
+        chatroomState.chatRoomUnread[chatRoomId].others.forEach(o => {
+          chatroomState.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.INTERACTIVE }, o))
        })
-        Vue.delete(state.chatRoomUnread[chatRoomId], 'others')
+        Vue.delete(chatroomState.chatRoomUnread[chatRoomId], 'others')


I think we can delete this whole section now since the groups will need to be recreated anyway.

Yeah, correct. As we can see in the comment above, we could clear the state/vuex/postUpgradeVerification as we have already published version 0.2.0.

Silver-IT

I don't find any issues too.

Silver-IT · 2024-02-23T11:10:11Z

frontend/model/state.js

+    const chatroomState = state.chatroom || {}
    // TODO: need to remove the whole content after we release 0.2.*
-    for (const chatRoomId in state.chatRoomUnread) {
-      if (!state.chatRoomUnread[chatRoomId].messages) {
-        state.chatRoomUnread[chatRoomId].messages = []
+    for (const chatRoomId in chatroomState.chatRoomUnread) {
+      if (!chatroomState.chatRoomUnread[chatRoomId].messages) {
+        chatroomState.chatRoomUnread[chatRoomId].messages = []
      }
-      if (state.chatRoomUnread[chatRoomId].mentions) {
-        state.chatRoomUnread[chatRoomId].mentions.forEach(m => {
-          state.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.TEXT }, m))
+      if (chatroomState.chatRoomUnread[chatRoomId].mentions) {
+        chatroomState.chatRoomUnread[chatRoomId].mentions.forEach(m => {
+          chatroomState.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.TEXT }, m))
        })
-        Vue.delete(state.chatRoomUnread[chatRoomId], 'mentions')
+        Vue.delete(chatroomState.chatRoomUnread[chatRoomId], 'mentions')
      }
-      if (state.chatRoomUnread[chatRoomId].others) {
-        state.chatRoomUnread[chatRoomId].others.forEach(o => {
-          state.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.INTERACTIVE }, o))
+      if (chatroomState.chatRoomUnread[chatRoomId].others) {
+        chatroomState.chatRoomUnread[chatRoomId].others.forEach(o => {
+          chatroomState.chatRoomUnread[chatRoomId].messages.push(Object.assign({ type: MESSAGE_TYPES.INTERACTIVE }, o))
        })
-        Vue.delete(state.chatRoomUnread[chatRoomId], 'others')
+        Vue.delete(chatroomState.chatRoomUnread[chatRoomId], 'others')


Yeah, correct. As we can see in the comment above, we could clear the state/vuex/postUpgradeVerification as we have already published version 0.2.0.

* add chatroom/vuexModule.js with some boilerplate code in there * fix a linter error * move chat&DM related getters in state.js to the chatroom vuexModule * move all the chatroom-relateed mutations to the vuexModules * add chatroom vuexModule to store in state.js * a small bug-fix for re-login process * typo fix for the cypress failure * remove postUpgradeVerification code (resetting groups anyway) --------- Co-authored-by: Greg Slepak <[email protected]>

* Add limit to eventsAfter * Minor cleanup * Convert circularClassList.js into a class * Simplify streamEventsAfter * Remove a bit of debugging in addEntry * Handle read() error in streamEventsAfter * No longer reverse entries in streamEventsAfter * fix the double dialog box issue * Remove pepper, read secret from file and minimise the number of secrets * Signature verification * Remove groupContractID in chatroom contract attributes (#1847) * feat: removed groupContractID in chatroom attributes * fix: recovered package.json * chore: remove unnecessary getter * chore: updated manifest * Fix error to close CreatePoll modal by clicking sidebar (#1849) * fix: error to close CreatePoll modal by clicking sidebar * chore: added comment for better understanding * chore: fixed typo * fix: make notification after identity contract is fully synced (#1848) * #1851 - Fix the broken VoterAvatars.vue component (#1852) * add a fix for Prompt.vue not being closed properly * fix the broken VoterAvatars.vue * Replace checks to use _private instead of _private_ * Remove notifications while leaving group (#1859) * fix: error in removing notifications after leaving group * chore: random commit for running travis again * Encrypted files (#1858) * WIP upload files * Files uploading (wip) * Files uploading, HAPI integration (wip) * File upload and download * Encrypted files * Changes to dowload API for ergonomics and manifest processing * Avatar types * File caching * Documentation * Update avatar types in Message* classes * Fix flow errors * Remove streams check for Node.js * Fix tests & feedback * Fix tests & feedback (again) * Fix tests for Node 18 * Fix test Co-authored-by: Greg Slepak <[email protected]> --------- Co-authored-by: Greg Slepak <[email protected]> * Fix streams support * Fix error in getting updated with the user's profile after rejoining group (#1864) * fix: sharing new PEKs * chore: grunt pin:0.2.5 * chore: reverted grunt pin and removed manifest.json --------- Co-authored-by: Greg Slepak <[email protected]> * #1571 - Create vuex module for chat (#1854) * add chatroom/vuexModule.js with some boilerplate code in there * fix a linter error * move chat&DM related getters in state.js to the chatroom vuexModule * move all the chatroom-relateed mutations to the vuexModules * add chatroom vuexModule to store in state.js * a small bug-fix for re-login process * typo fix for the cypress failure * remove postUpgradeVerification code (resetting groups anyway) --------- Co-authored-by: Greg Slepak <[email protected]> * Fix issue #1857 * Fix incorrect badge while switching group (#1863) * fix: incorrect badge from direct messages * chore: grunt pin:0.2.4 * chore: reverted version 0.2.4 * chore: reverted the grunt pin:0.2.3 too * chore: removed manifest.json * fix the overflow bug * Fix error to display profile picture for DMs with more than 2 people (#1869) * fix: error to select avatar for direct messages * chore: follow-up process for changes of getters * fix: error in getting direct messages by groupID * fix: syntax error * 32 logging (#1870) * pino enabled, still need to fix logging behavior though * fix flow errors * pino support seems to be working * one minor fix for %s strings. Closes #32 * fix some error logging in pubsub + remove hapi-pino * Convert eventsAfter to stream (missing: change usage in ChatMain) * API improvements * Endpoint consolidation * Fix subscriptionSet issues * Fix chatroom race condition * Log instead of throw * Cleaning up * Linting --------- Co-authored-by: snowteamer <[email protected]> Co-authored-by: SebinSong <[email protected]> Co-authored-by: Alex Jin <[email protected]> Co-authored-by: Greg Slepak <[email protected]>

SebinSong added 8 commits February 15, 2024 13:05

add chatroom/vuexModule.js with some boilerplate code in there

7d24ef7

Merge remote-tracking branch 'origin/master' into sebin/task/#1571-cr…

9b71d30

…eate-vuex-module-for-chat

fix a linter error

91a8b73

move chat&DM related getters in state.js to the chatroom vuexModule

2044db5

move all the chatroom-relateed mutations to the vuexModules

457c2d7

add chatroom vuexModule to store in state.js

e33b4d8

a small bug-fix for re-login process

c0b8f07

merge the latest main in

5a8aaf7

SebinSong self-assigned this Feb 20, 2024

SebinSong changed the title ~~#1571 - Create vuex module for chat~~ [ WIP ] #1571 - Create vuex module for chat Feb 20, 2024

typo fix for the cypress failure

414447f

SebinSong changed the title ~~[ WIP ] #1571 - Create vuex module for chat~~ #1571 - Create vuex module for chat Feb 20, 2024

taoeffect previously approved these changes Feb 21, 2024

View reviewed changes

taoeffect requested review from corrideat and Silver-IT February 21, 2024 20:03

merge the latest main in

6995d07

SebinSong dismissed taoeffect’s stale review via 6995d07 February 22, 2024 21:48

Silver-IT previously approved these changes Feb 23, 2024

View reviewed changes

taoeffect mentioned this pull request Feb 23, 2024

Fix incorrect badge while switching group #1863

Merged

corrideat previously approved these changes Feb 23, 2024

View reviewed changes

taoeffect added 2 commits February 23, 2024 09:04

Merge branch 'master' into sebin/task/#1571-create-vuex-module-for-chat

de40165

remove postUpgradeVerification code (resetting groups anyway)

f95234b

taoeffect dismissed stale reviews from corrideat and Silver-IT via f95234b February 23, 2024 17:11

taoeffect approved these changes Feb 23, 2024

View reviewed changes

taoeffect merged commit 839a132 into master Feb 23, 2024
4 checks passed

taoeffect deleted the sebin/task/#1571-create-vuex-module-for-chat branch February 23, 2024 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1571 - Create vuex module for chat #1854

#1571 - Create vuex module for chat #1854

SebinSong commented Feb 20, 2024 •

edited

Loading

cypress bot commented Feb 20, 2024 •

edited

Loading

taoeffect left a comment

taoeffect Feb 21, 2024

Silver-IT Feb 23, 2024

Silver-IT left a comment

Silver-IT Feb 23, 2024

#1571 - Create vuex module for chat #1854

#1571 - Create vuex module for chat #1854

Conversation

SebinSong commented Feb 20, 2024 • edited Loading

cypress bot commented Feb 20, 2024 • edited Loading

Passing run #1910 ↗︎

Review all test suite changes for PR #1854 ↗︎

taoeffect left a comment

Choose a reason for hiding this comment

taoeffect Feb 21, 2024

Choose a reason for hiding this comment

Silver-IT Feb 23, 2024

Choose a reason for hiding this comment

Silver-IT left a comment

Choose a reason for hiding this comment

Silver-IT Feb 23, 2024

Choose a reason for hiding this comment

SebinSong commented Feb 20, 2024 •

edited

Loading

cypress bot commented Feb 20, 2024 •

edited

Loading