Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging on backend #32

Closed
taoeffect opened this issue Mar 28, 2016 · 2 comments · Fixed by #1870
Closed

Improve logging on backend #32

taoeffect opened this issue Mar 28, 2016 · 2 comments · Fixed by #1870
Assignees
@taoeffect
Labels
App:Backend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter

Comments

@taoeffect
Copy link
Member

taoeffect commented Mar 28, 2016 •
edited
Loading

Problem

  • it's unclear how to log errors properly
  • on travis it's too verbose
  • needs colors

Solution

EDIT:

  • See Pino and popular debug logging libraries, very fast
  • bunyan was also recommended here and while it's not as fast as pino or debug, it's faster than winston
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Backend Kind:Test Level:Starter labels Mar 28, 2016
@danawoodman
Copy link
Contributor

@taoeffect I'd like to take this on if that's ok. I would propose we use winston which we can hook up to any logging backend. Also, we can set log levels in our tests suites which would remove logs there (big win for test suite readability). Thoughts?

@taoeffect
Copy link
Member Author

@danawoodman As this is not critical for getting the prototype out the door, let's put this off for a bit

@taoeffect taoeffect self-assigned this Feb 23, 2024
@taoeffect taoeffect mentioned this issue Feb 27, 2024
Merged
taoeffect added a commit that referenced this issue Feb 27, 2024
@taoeffect
one minor fix for %s strings. Closes #32
e3d5994
taoeffect added a commit that referenced this issue Feb 28, 2024
@taoeffect
32 logging (#1870)
65b1874 
* pino enabled, still need to fix logging behavior though

* fix flow errors

* pino support seems to be working

* one minor fix for %s strings. Closes #32

* fix some error logging in pubsub + remove hapi-pino
corrideat pushed a commit that referenced this issue Mar 4, 2024
@taoeffect @corrideat
32 logging (#1870)
4fa4074 
* pino enabled, still need to fix logging behavior though

* fix flow errors

* pino support seems to be working

* one minor fix for %s strings. Closes #32

* fix some error logging in pubsub + remove hapi-pino
corrideat pushed a commit that referenced this issue Mar 4, 2024
@taoeffect @corrideat
32 logging (#1870)
d754ba6 
* pino enabled, still need to fix logging behavior though

* fix flow errors

* pino support seems to be working

* one minor fix for %s strings. Closes #32

* fix some error logging in pubsub + remove hapi-pino
taoeffect added a commit that referenced this issue Mar 14, 2024
@corrideat @snowteamer
@SebinSong @Silver-IT @taoeffect
Limit events after (#1876)
ef7f542 
* Add limit to eventsAfter

* Minor cleanup

* Convert circularClassList.js into a class

* Simplify streamEventsAfter

* Remove a bit of debugging in addEntry

* Handle read() error in streamEventsAfter

* No longer reverse entries in streamEventsAfter

* fix the double dialog box issue

* Remove pepper, read secret from file and minimise the number of secrets

* Signature verification

* Remove groupContractID in chatroom contract attributes (#1847)

* feat: removed groupContractID in chatroom attributes

* fix: recovered package.json

* chore: remove unnecessary getter

* chore: updated manifest

* Fix error to close CreatePoll modal by clicking sidebar (#1849)

* fix: error to close CreatePoll modal by clicking sidebar

* chore: added comment for better understanding

* chore: fixed typo

* fix: make notification after identity contract is fully synced (#1848)

* #1851 - Fix the broken VoterAvatars.vue component (#1852)

* add a fix for Prompt.vue not being closed properly

* fix the broken VoterAvatars.vue

* Replace checks to use _private instead of _private_

* Remove notifications while leaving group (#1859)

* fix: error in removing notifications after leaving group

* chore: random commit for running travis again

* Encrypted files (#1858)

* WIP upload files

* Files uploading (wip)

* Files uploading, HAPI integration (wip)

* File upload and download

* Encrypted files

* Changes to dowload API for ergonomics and manifest processing

* Avatar types

* File caching

* Documentation

* Update avatar types in Message* classes

* Fix flow errors

* Remove streams check for Node.js

* Fix tests & feedback

* Fix tests & feedback (again)

* Fix tests for Node 18

* Fix test

Co-authored-by: Greg Slepak <[email protected]>

---------

Co-authored-by: Greg Slepak <[email protected]>

* Fix streams support

* Fix error in getting updated with the user's profile after rejoining group (#1864)

* fix: sharing new PEKs

* chore: grunt pin:0.2.5

* chore: reverted grunt pin and removed manifest.json

---------

Co-authored-by: Greg Slepak <[email protected]>

* #1571 - Create vuex module for chat (#1854)

* add chatroom/vuexModule.js with some boilerplate code in there

* fix a linter error

* move chat&DM related getters in state.js to the chatroom vuexModule

* move all the chatroom-relateed mutations to the vuexModules

* add chatroom vuexModule to store in state.js

* a small bug-fix for re-login process

* typo fix for the cypress failure

* remove postUpgradeVerification code (resetting groups anyway)

---------

Co-authored-by: Greg Slepak <[email protected]>

* Fix issue #1857

* Fix incorrect badge while switching group (#1863)

* fix: incorrect badge from direct messages

* chore: grunt pin:0.2.4

* chore: reverted version 0.2.4

* chore: reverted the grunt pin:0.2.3 too

* chore: removed manifest.json

* fix the overflow bug

* Fix error to display profile picture for DMs with more than 2 people (#1869)

* fix: error to select avatar for direct messages

* chore: follow-up process for changes of getters

* fix: error in getting direct messages by groupID

* fix: syntax error

* 32 logging (#1870)

* pino enabled, still need to fix logging behavior though

* fix flow errors

* pino support seems to be working

* one minor fix for %s strings. Closes #32

* fix some error logging in pubsub + remove hapi-pino

* Convert eventsAfter to stream (missing: change usage in ChatMain)

* API improvements

* Endpoint consolidation

* Fix subscriptionSet issues

* Fix chatroom race condition

* Log instead of throw

* Cleaning up

* Linting

---------

Co-authored-by: snowteamer <[email protected]>
Co-authored-by: SebinSong <[email protected]>
Co-authored-by: Alex Jin <[email protected]>
Co-authored-by: Greg Slepak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taoeffect taoeffect

Labels
App:Backend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

32 logging okTurtles/group-income
2 participants
@taoeffect @danawoodman