#1851 - Fix the broken VoterAvatars.vue component #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Feb 20, 2024
| }, | ||
| submit () { | ||
| sbp('okTurtles.events/emit', MODAL_RESPONSE, true) | ||
| this.$refs.modal.close() | ||
| this.$refs.modal.unload() |
There was a problem hiding this comment.
This is not related to the issue itself but it's a bug-fix for an issue I encountered where once the prompt modal is dismissed the entire page is frozen.
SebinSong
commented
Feb 20, 2024
| const getDisplayName = (memberID) => { | ||
| const profile = this.globalProfile(memberID) | ||
| return profile?.displayName || profile?.username || memberID | ||
| } |
There was a problem hiding this comment.
just DRYing the getDisplayname method here.
Passing run #1884 ↗︎
Details:
Review all test suite changes for PR #1852 ↗︎ |
|||||||||||||||
corrideat
pushed a commit
that referenced
this pull request
Mar 4, 2024
* add a fix for Prompt.vue not being closed properly * fix the broken VoterAvatars.vue
corrideat
pushed a commit
that referenced
this pull request
Mar 4, 2024
* add a fix for Prompt.vue not being closed properly * fix the broken VoterAvatars.vue
taoeffect
added a commit
that referenced
this pull request
Mar 14, 2024
* Add limit to eventsAfter * Minor cleanup * Convert circularClassList.js into a class * Simplify streamEventsAfter * Remove a bit of debugging in addEntry * Handle read() error in streamEventsAfter * No longer reverse entries in streamEventsAfter * fix the double dialog box issue * Remove pepper, read secret from file and minimise the number of secrets * Signature verification * Remove groupContractID in chatroom contract attributes (#1847) * feat: removed groupContractID in chatroom attributes * fix: recovered package.json * chore: remove unnecessary getter * chore: updated manifest * Fix error to close CreatePoll modal by clicking sidebar (#1849) * fix: error to close CreatePoll modal by clicking sidebar * chore: added comment for better understanding * chore: fixed typo * fix: make notification after identity contract is fully synced (#1848) * #1851 - Fix the broken VoterAvatars.vue component (#1852) * add a fix for Prompt.vue not being closed properly * fix the broken VoterAvatars.vue * Replace checks to use _private instead of _private_ * Remove notifications while leaving group (#1859) * fix: error in removing notifications after leaving group * chore: random commit for running travis again * Encrypted files (#1858) * WIP upload files * Files uploading (wip) * Files uploading, HAPI integration (wip) * File upload and download * Encrypted files * Changes to dowload API for ergonomics and manifest processing * Avatar types * File caching * Documentation * Update avatar types in Message* classes * Fix flow errors * Remove streams check for Node.js * Fix tests & feedback * Fix tests & feedback (again) * Fix tests for Node 18 * Fix test Co-authored-by: Greg Slepak <[email protected]> --------- Co-authored-by: Greg Slepak <[email protected]> * Fix streams support * Fix error in getting updated with the user's profile after rejoining group (#1864) * fix: sharing new PEKs * chore: grunt pin:0.2.5 * chore: reverted grunt pin and removed manifest.json --------- Co-authored-by: Greg Slepak <[email protected]> * #1571 - Create vuex module for chat (#1854) * add chatroom/vuexModule.js with some boilerplate code in there * fix a linter error * move chat&DM related getters in state.js to the chatroom vuexModule * move all the chatroom-relateed mutations to the vuexModules * add chatroom vuexModule to store in state.js * a small bug-fix for re-login process * typo fix for the cypress failure * remove postUpgradeVerification code (resetting groups anyway) --------- Co-authored-by: Greg Slepak <[email protected]> * Fix issue #1857 * Fix incorrect badge while switching group (#1863) * fix: incorrect badge from direct messages * chore: grunt pin:0.2.4 * chore: reverted version 0.2.4 * chore: reverted the grunt pin:0.2.3 too * chore: removed manifest.json * fix the overflow bug * Fix error to display profile picture for DMs with more than 2 people (#1869) * fix: error to select avatar for direct messages * chore: follow-up process for changes of getters * fix: error in getting direct messages by groupID * fix: syntax error * 32 logging (#1870) * pino enabled, still need to fix logging behavior though * fix flow errors * pino support seems to be working * one minor fix for %s strings. Closes #32 * fix some error logging in pubsub + remove hapi-pino * Convert eventsAfter to stream (missing: change usage in ChatMain) * API improvements * Endpoint consolidation * Fix subscriptionSet issues * Fix chatroom race condition * Log instead of throw * Cleaning up * Linting --------- Co-authored-by: snowteamer <[email protected]> Co-authored-by: SebinSong <[email protected]> Co-authored-by: Alex Jin <[email protected]> Co-authored-by: Greg Slepak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1851