Doesn't pick a theme

[evmorov]

Colors in a build result are always black. Changing a theme doesn't affect the colors.

Environment:

• Atom 1.5.4
• OS X 10.11.3
• build 0.56.0 (the bug exists since this version)

[evmorov]

Sure the problem is in term.js that was picked up in fe7e2c2. Now I don't see many advantages in this package over tons of packages that somehow use term.js. Before this we had had a lot of control of output.

[noseglid]

This is a doozy. The "terminal" defines colors as "red" and "blue", which doesn't really match with a theme since they "set the colors of borders, text etc".
What a theme may want to do is redefine what "red" means, but this also means it may deviate from what the creator of the CLI tool intended.

Now maybe we should have a way to override the colors for themes. This would include changing term.js to add classes to colored output rather than actually setting the style attribute.

Either way, I'm all for adding ways to control the color.

I hope there are other good qualities with this plugin than the control of the colors in the build output :)

[evmorov]

I hope there are other good qualities with this plugin than the control of the colors in the build output :)

I'm sure that many people use this package only as a test runner. Features in this package that are useful:

1. You run a command and if it's green a window disappears, if not it stays
2. You have commands per project (rspec {FILE_ACTIVE} for Ruby, ant test for Java, etc.)
3. The package has potential: you can create error file paths clickable, you can add a test summary block (like in IDEA IDE). Because of this potential we had right colors in an output

For now, the package doesn't have the point 3. Points 1 and 2 people can be emulated with terminal packages (they have many features but as this package they have the same huge problems with colors).

[evmorov]

Now maybe we should have a way to override the colors for themes. This would include changing term.js to add classes to colored output rather than actually setting the style attribute.

Do you really think that it's possible? If it is I'm not sure that it's easy. Spacemacs uses just buffers for command output (not a terminal), vim doesn't use a terminal for this, IDEs sure don't use a terminal for this. But of course, they can do it if they wanted. But why should they do it? What are positive things about using a full terminal instead of using just a pane?

[noseglid]

What are positive things about using a full terminal instead of using just a pane?

The primary reason are all the controls sequences, which gives the ability to produce a very rich console output.

Do you really think that it's possible?

Of course it's possible to add classes to the output of term.js.

doesn't use a terminal for this, [...] why should they do it?

These tools were (almost always) built to run in a terminal, that's why I want to run them in a terminal. The output can be colored. Progress bars can be shown. It's all a nice appearance experience!

As long as the features you deem valuable goes, I value a few others too: specify ways to run tools which rely on multiple environment settings, having a compiler re-compile on change and show the state next to the code I edit, etc. I'm sure other people have other uses/needs.

[evmorov]

Thank you for your extended response. Hope the functionality of coloring an output properly will be easy to return.

[noseglid]

Thank you for taking the time to report this and voice your concerns. This is how we become better!

[TarrX]

Had to downgrade to 0.55.0 again, I see the reasoning behind using a terminal, but a black background with almost not readable grey fonts, no coloring or underlining on my machine makes the whole package not very useful, which is a pity.

[noseglid]

@TarrX Could you detail what you mean with almost not readable grey fonts ? A screenshot perhaps?

[noseglid]

I've thought more about this, and setting the background on the terminal to whatever the theme defines as background on a panel is quite easy. I'll try and get around to that soon.

However, ANSI colors are defined as being on a black background - but you already seem to be happy with the end result, so a configuration for "forcing black background" or "using theme default" seems to be in order.

[aphecetche]

Hi,

Just to add my 2 cents. Indeed the last update of the plugin brought a not-so-nice visual difference with the preceeding version I was quite happy with. See the black background with "almost not readable grey fonts" (meaning I can relate to that comment ;-) ) in the attached screenshot.

[noseglid]

Hello @aphecetche
Thanks for your input. If you add

.build .output {
  background-color: unset;
}

To your custom stylesheet (Command Palette > Application: Open Your Stylesheet). Is this the visuals you'd expect?

ping @evmorov @TarrX could you also try above?

[aphecetche]

Absolutely. Thanks.

[evmorov]

Works. @noseglid, thanks.

[noseglid]

I'll add an option to override the theme's color with black. That way one can opt out and have the theme colors instead.

[tesselode]

I recently updated to the newest version (not sure which version I was on previously), and the terminal has some really gross fonts now.

Do you think this is a related issue to what @TarrX and @aphecetche were experiencing or something else?

[noseglid]

@tesselode It's something different, but what you found was addressed in #340 which is already merged. It can hopefully have a release out alter today

[TarrX]

Sorry for the late answer, my visual experience is basically the same @aphecetche and @tesselode has. I am using ArchLinux and OneLight as UI and Syntax Theme.