Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally override theme with terminal style #341

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Conversation

noseglid
Copy link
Owner

Terminal works "best" under black background and white
text. However this may not look very good with light theme,
or other dark themes. Allow user to opt out of overriden
colors.

Fixes #338

Terminal works "best" under black background and white
text. However this may not look very good with light theme,
or other dark themes. Allow user to opt out of overriden
colors.

Fixes #338
@nixpulvis
Copy link

Missing the left border when I tried it.

screen shot 2016-03-15 at 2 25 37 am

@noseglid
Copy link
Owner Author

As you can see, there's no border on the status panel either. I'm not sure whether it's really the responsibility of this package to put borders on the panel. The panel is a built in Atom component which a theme can modify. Which theme are you using. Maybe you can open an issue there?

Optionally you could add this to your stylesheet:

atom-panel {
  border-left: solid 1px @tool-panel-border-color;
}

If you just want a border on the build panel, set the selector to atom-panel .build instead.

@nixpulvis
Copy link

This is just the One Light theme, I'm not really sure what should be considered a panel or not. But this is the only package I have doing this at the moment, granted I don't have other packages that pop up in the same place.

@noseglid
Copy link
Owner Author

I see. I do not know the reasoning behind not having borders on panels. I admit it does look too integrated with the tree view.

@noseglid
Copy link
Owner Author

From what I can tell it's the One theme's that have this issue. Atom Dark and Atom Light sets a border on the tree view resulting in expected visuals:
screen shot 2016-03-15 at 08 52 36

I'd say it's definitely an "issue" (or design choice, who knows) with the One themes.

@nixpulvis
Copy link

I'll open an issue in that theme and see what they say.

noseglid added a commit that referenced this pull request Mar 15, 2016
Optionally override theme with terminal style
@noseglid noseglid merged commit 2835251 into master Mar 15, 2016
@noseglid noseglid deleted the override-theme branch March 15, 2016 17:41
@noseglid
Copy link
Owner Author

I'd be happy to chime in if you post the link to the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants