Use the editor font-family #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| .build { | |||
|
|
|||
| min-width: 250px; | |||
| font-family: Menlo; | |||
| font-family: monospace; | |||
There was a problem hiding this comment.
What about having: 'Menlo', 'Consolas', 'DejaVu Sans Mono', monospace as default rather (as it was before)?
I'm happy to merge this, and make that change myself. I want your opinion though :)
There was a problem hiding this comment.
I don't think this is required at all, since an actual font-family will be fetched from config, so generally user won't see a font defined here. I think it's fine to set some fancy fonts here just in case something really bad happens :)
|
Thanks for fixing this! Much appreciated! |
|
Glad to help! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.