chore(ssa): Do not print entire functions in underconstrained values check trace #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
Mar 11, 2025
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 12, 2025
…noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
TomAFrench
added a commit
that referenced
this pull request
Mar 12, 2025
* master: chore: update yarn version to 4.5.2 (#7678) chore: migrate to use new flat eslint config file (#7676) chore: bump JS dependencies (#7669) chore: bump wasm-pack to 0.13.1 (#7675) chore: bump node to v22.18.3 (#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (#7664) fix: correctly format let followed by comment before unsafe (#7659) chore: bump external pinned commits (#7667) chore: fixing timeouts (#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (#7665) chore(ci): Exclude enum tests from Brillig reports (#7661) chore: add regression tests for PR #7570 from lambda interpreter test (#7638) chore: remove some unused HIR code (#7643) chore: update examples to use UltraHonk (#7653) fix: allow method call after block, if and match (#7655) chore: address recurring typo in docs (#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (#7644) chore: bump external pinned commits (#7640)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 13, 2025
…d to cover multiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 13, 2025
…ultiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
No issue just something I noticed while running a Noir program with a trace activated.
Summary*
We should not be printing the entire function where we may have tainted Brillig calls. A function's SSA could potentially be massive. This litters the trace and also most likely affects our compilation timing reports (which have
NOIR_LOG=traceactivated) as we are printing much more than necessary.This was initially done here #6814 but looks like a trace was missed. We now use a combo of function name and id.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.