-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Exclude enum tests from Brillig reports #7661
Conversation
… reports working again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We could also pass -Zenums
to reports, though I guess it's not very useful if it's just for one regression test.
Yeah that is what I thought. I also felt passing experimental flags to our tests could come in its own PR. Here I just wanted to get the reports working again. |
…noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
* master: chore: update yarn version to 4.5.2 (#7678) chore: migrate to use new flat eslint config file (#7676) chore: bump JS dependencies (#7669) chore: bump wasm-pack to 0.13.1 (#7675) chore: bump node to v22.18.3 (#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (#7664) fix: correctly format let followed by comment before unsafe (#7659) chore: bump external pinned commits (#7667) chore: fixing timeouts (#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (#7665) chore(ci): Exclude enum tests from Brillig reports (#7661) chore: add regression tests for PR #7570 from lambda interpreter test (#7638) chore: remove some unused HIR code (#7643) chore: update examples to use UltraHonk (#7653) fix: allow method call after block, if and match (#7655) chore: address recurring typo in docs (#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (#7644) chore: bump external pinned commits (#7640)
…d to cover multiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
…ultiple `beta.n` releases (noir-lang/noir#7685) chore(docs): Minor fixes on local documentation development workflows (noir-lang/noir#7684) chore: add trailing slash to link on docs homepage (noir-lang/noir#7682) fix: allow referring to comptime locals at runtime (noir-lang/noir#7681) chore: easier way to test monormophization errors (noir-lang/noir#7679) chore(docs): update bb commands to match the new version (noir-lang/noir#7677) chore: update yarn version to 4.5.2 (noir-lang/noir#7678) chore: migrate to use new flat eslint config file (noir-lang/noir#7676) chore: bump JS dependencies (noir-lang/noir#7669) chore: bump wasm-pack to 0.13.1 (noir-lang/noir#7675) chore: bump node to v22.18.3 (noir-lang/noir#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (noir-lang/noir#7664) fix: correctly format let followed by comment before unsafe (noir-lang/noir#7659) chore: bump external pinned commits (noir-lang/noir#7667) chore: fixing timeouts (noir-lang/noir#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (noir-lang/noir#7665) chore(ci): Exclude enum tests from Brillig reports (noir-lang/noir#7661) chore: add regression tests for PR #7570 from lambda interpreter test (noir-lang/noir#7638) chore: remove some unused HIR code (noir-lang/noir#7643) chore: update examples to use UltraHonk (noir-lang/noir#7653) fix: allow method call after block, if and match (noir-lang/noir#7655) chore: address recurring typo in docs (noir-lang/noir#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (noir-lang/noir#7644)
Description
Problem*
In #7660 I was not getting an opcode diff that I am getting locally.
Although the CI jobs for the Brillig opcode reports are passing, we are getting this failure:
Here is an example from an entirely unrelated PR where we see the same failure: https://github.com/noir-lang/noir/actions/runs/13788593062/job/38562554298?pr=7659
Summary*
Exclude tests that use enums from the Brillig reports. Right now this is just
regression_7323
.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.