Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa): Do not print entire functions in underconstrained values check trace #7665

Merged
merged 2 commits into from
Mar 11, 2025
Merged

chore(ssa): Do not print entire functions in underconstrained values check trace #7665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea9beb3
do not print entire function is underconstrained values trace
vezenovm Mar 11, 2025
759168a
cargo fmt
vezenovm Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,12 @@ impl DependencyContext {
function: &Function,
all_functions: &BTreeMap<FunctionId, Function>,
) {
trace!("processing instructions of block {} of function {}", block, function.id());
trace!(
"processing instructions of block {} of function {} {}",
block,
function.name(),
function.id()
);

// First, gather information on all Brillig calls in the block
// to be able to follow their arguments first appearing in the
Expand Down Expand Up @@ -548,8 +553,9 @@ impl DependencyContext {

if !self.tainted.is_empty() {
trace!(
"number of Brillig calls in function {} left unchecked: {}",
function,
"number of Brillig calls in function {} {} left unchecked: {}",
function.name(),
function.id(),
self.tainted.len()
);
}
Expand All @@ -573,9 +579,10 @@ impl DependencyContext {
.collect();

trace!(
"making {} reports on underconstrained Brillig calls for function {}",
"making {} reports on underconstrained Brillig calls for function {} {}",
warnings.len(),
function.name()
function.name(),
function.id()
);
warnings
}
Expand Down
Loading