Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not double-encode mailto parameters #2569

Closed
wants to merge 1 commit into from
Closed

Do not double-encode mailto parameters #2569

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

Steps to reproduce

Before: get the new message page with an email like user%40domain.tld filled in
After: get new message page with [email protected] filled in

The reason for this bug is that parse_url does not URL decode the parameters, hence they ended up being encoded twice.

@ChristophWurst ChristophWurst added this to the next milestone Jan 28, 2020
@ChristophWurst ChristophWurst self-assigned this Jan 28, 2020
GretaD
GretaD approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice Noice!

@ChristophWurst ChristophWurst mentioned this pull request Jan 28, 2020
Merged
@ChristophWurst
Copy link
Member Author

nextcloud/server#19176 actually replaces this PR.

@ChristophWurst ChristophWurst deleted the fix/mailto-redirect-double-encoding branch January 28, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@GretaD GretaD GretaD approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review bug
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @GretaD