Do not encode contacts menu mailto links #19176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
rullzer,
nickvergessen,
georgehrke,
juliusknorr and
kesselb
|
/backport to stable18 |
|
/backport to stable17 |
|
/backport to stable16 |
georgehrke
approved these changes
Jan 28, 2020
nickvergessen
approved these changes
Jan 28, 2020
ChristophWurst
added
4. to release
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/contacts-menu-mailt-encoding
branch
from
6b9cd93 to
87ec729
Compare
|
backport to stable18 in #19207 |
|
backport to stable17 in #19208 |
|
backport to stable16 in #19209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing unit tests for nextcloud/mail#2569 I realized that our mailto links look different to other examples on the internet. Ours use
%40in thehrefand the others just use@. Also https://www.lifewire.com/constructing-mailto-urls-1166417 shows that you only need to encodesubjector other enhanced props (not relevant here).In any case, I think we should remove the encoding. Links then work fine with Mail, but also with Gnome Evolution. I do not have other clients at hand to test. I also tried to inject HTML with an invalid contacts email address but we escape that on a HTML level when the
<a>is rendered.