Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mailto: protocol handler #2539

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add mailto: protocol handler #2539

merged 1 commit into from
Jan 24, 2020

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 24, 2020

fixes #2535

@GretaD GretaD requested a review from ChristophWurst January 24, 2020 09:58
ChristophWurst
ChristophWurst requested changes Jan 24, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the lint autofixer and add logging to the catch block. That will make it easier to debug when mailto doesn't work :)

@ChristophWurst ChristophWurst added this to the next milestone Jan 24, 2020
ChristophWurst
ChristophWurst requested changes Jan 24, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise works as expected. Noice!

@GretaD GretaD requested a review from ChristophWurst January 24, 2020 12:36
@ChristophWurst ChristophWurst merged commit 9f254d8 into master Jan 24, 2020
@ChristophWurst ChristophWurst deleted the mailto_button branch January 24, 2020 12:51
@ChristophWurst ChristophWurst mentioned this pull request Jan 28, 2020
Closed
@ChristophWurst ChristophWurst mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@GretaD GretaD

Labels
4. to release bug regression
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Mailto protocol handler vanished
2 participants
@GretaD @ChristophWurst