Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily stop listing the official Chrome extension in the main README" #16601

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Revert "Temporarily stop listing the official Chrome extension in the main README" #16601

merged 1 commit into from
Jul 1, 2023

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Jun 25, 2023

This restores the mention of the extension listing by reverting #15452.

The Chrome Web Store has an updated version (#13669 (comment)) and will continue to receive updates as needed.

@Rob--W
Copy link
Member Author

Rob--W commented Jun 25, 2023

Note: not ready to merge yet because the lint-chromium task fails. I'll investigate and submit separate PRs to fix that, then rebase this PR.

@Snuffleupagus
Copy link
Collaborator

Note: not ready to merge yet because the lint-chromium task fails. I'll investigate and submit separate PRs to fix that, then rebase this PR.

Running gulp lint-chromium locally against the master branch works for me, perhaps fixed just now by PR #16605?

@Rob--W Rob--W mentioned this pull request Jun 26, 2023
Merged
@Rob--W Rob--W force-pushed the crx-maintained-again branch from 6731d9e to 9aedf00 Compare June 26, 2023 16:54
@Rob--W
Copy link
Member Author

Rob--W commented Jun 26, 2023

Note: not ready to merge yet because the lint-chromium task fails. I'll investigate and submit separate PRs to fix that, then rebase this PR.

Running gulp lint-chromium locally against the master branch works for me, perhaps fixed just now by PR #16605?

That assessment is accurate :) Nevertheless, to make it easier to debug future instances of the issue without debugging locally, I've improved the output of the linter warnings in #16607.

@timvandermeij timvandermeij merged commit 94015c7 into mozilla:master Jul 1, 2023
@timvandermeij
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
addon chrome-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rob--W @Snuffleupagus @timvandermeij