Temporarily stop listing the official Chrome extension in the main README #15452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ADME The [official Chrome extension](https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm) has unfortunately not been updated for *three years*, which means that it's currently missing out on years worth of bug fixes, performance improvements, and new features. In particular, the Chrome extension suffers from a known bug with non-embedded standard fonts; see issue 13669 for details. For the time being, this patch proposes that we *temporary* make the following changes: - Remove the mention of the official Chrome extension from the main README, since it seems unfortunate to somewhat prominently recommend users an old and partially non-working extension. - Don't run the `gulp lint-chromium` task as part of the CI, since in addition to the official extension not having been updated its code is also not being actively maintained.[1] Once the official Chrome extension has been updated, and it's being actively maintained again, this patch should be simple enough to revert. --- [1] The last commits, which aren't e.g. linting or general code-maintenance related, happened a year ago now.
timvandermeij
approved these changes
Sep 18, 2022
|
Thanks! Let's hope the extension gets updated soon again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Chrome extension has unfortunately not been updated for three years, which means that it's currently missing out on years worth of bug fixes, performance improvements, and new features. In particular, the Chrome extension suffers from a known bug with non-embedded standard fonts; see issue 13669 for details.
For the time being, this patch proposes that we temporary make the following changes:
gulp lint-chromiumtask as part of the CI, since in addition to the official extension not having been updated its code is also not being actively maintained.[1]Once the official Chrome extension has been updated, and it's being actively maintained again, this patch should be simple enough to revert.
[1] The last commits, which aren't e.g. linting or general code-maintenance related, happened a year ago now.