Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeckoView] Remove the enableFloatingToolbar preference #16605

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Note that we'll now display the toolbar unconditionally in GeckoView.

Note that we'll now display the toolbar unconditionally in GeckoView.
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit d357906 into mozilla:master Jun 26, 2023
@Snuffleupagus Snuffleupagus deleted the rm-enableFloatingToolbar-pref branch June 26, 2023 14:00
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Sep 17, 2024
…e. r=pdfjs-reviewers,calixte

This preference was removed upstream in mozilla/pdf.js#16605, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1840990, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D222306
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 17, 2024
…e. r=pdfjs-reviewers,calixte

This preference was removed upstream in mozilla/pdf.js#16605, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1840990, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D222306
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Sep 17, 2024
…e. r=pdfjs-reviewers,calixte

This preference was removed upstream in mozilla/pdf.js#16605, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1840990, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D222306
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Sep 20, 2024
…e. r=pdfjs-reviewers,calixte

This preference was removed upstream in mozilla/pdf.js#16605, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1840990, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D222306

UltraBlame original commit: 965b34035cba8ba94141f086158098e5e4d512d6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Sep 20, 2024
…e. r=pdfjs-reviewers,calixte

This preference was removed upstream in mozilla/pdf.js#16605, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1840990, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D222306

UltraBlame original commit: 965b34035cba8ba94141f086158098e5e4d512d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants