-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate upgrading Gulp, Webpack and Node.js dependencies #10177
Comments
The problem is that Webpack, starting from version typeof __non_webpack_require__ !== 'undefined' expression during the build process, causing the above line to be reduced to typeof require !== 'undefined' According to the documentation, this should still work; see https://webpack.js.org/api/module-variables/#__non_webpack_require__-webpack-specific- If someone has time (since a reduced test-case might be needed), this should be reported to https://github.com/webpack/webpack/issues |
Gulp and Node.js are taken care of in the meantime, only Webpack remains. |
Was the Webpack regression described in #10177 (comment) ever reported upstream, or has it perhaps already been fixed in a later release? (You could probably hack around this on the PDF.js side, by using e.g. |
I tried the latest release last time I updated the dependencies and it isn't fixed yet, nor do I really know how to report this in a way that it's actionable for upstream because I don't know that much about this part of the codebase to reduce it to a minimal example. |
I have filed an upstream issue for this bug at webpack/webpack#8829. If that is fixed, we can remove the workaround. Tracking this upstream now. |
From #10176:
The text was updated successfully, but these errors were encountered: