Fix webpack example #10244
Merged
Fix webpack example #10244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dardinier
commented
Nov 9, 2018
dardinier
commented
- Close issue Problem of webpack version in webpack example #10237
|
@Snuffleupagus Fixed |
timvandermeij
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Looks good. Could you squash the commits into one? Refer to https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for how to do that easily if you're not familiar with the process.
|
Hi @timvandermeij, I squashed the commits into one commit. |
Fix package.json after review
|
✔️ Done @Snuffleupagus |
timvandermeij
approved these changes
Nov 12, 2018
|
Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.