Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to *temporarily* hack around the __non_webpack_require__ bug, and update Webpack to the latest stable version (issue 10177) #10578

Merged
merged 2 commits into from
Feb 24, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

  • Try to temporarily hack around the __non_webpack_require__ bug (issue 10177)

    In order to, quickly, unblock future Webpack updates this patch implements a temporary work-around for the regression; please refer to issue Investigate upgrading Gulp, Webpack and Node.js dependencies #10177 for additional details.
    Please note that this patch doesn't require any changes to the source code, but only (small) build-time changes to gulpfile.js and as such will be easy to revert.

  • Update Webpack to the latest stable version (4.29.5)

…ssue 10177)

In order to, quickly, unblock future Webpack updates this patch implements a *temporary* work-around for the regression; please refer to issue 10177 for additional details.
Please note that this patch doesn't require *any* changes to the source code, but only (small) build-time changes to `gulpfile.js` and as such will be easy to revert.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d1fb16a2bb19809/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/d1fb16a2bb19809/output.txt

Total script time: 1.95 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f904259aa92720e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/5c881d1ffeab778/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/f904259aa92720e/output.txt

Total script time: 17.96 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/5c881d1ffeab778/output.txt

Total script time: 26.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 77a7e04 into mozilla:master Feb 24, 2019
@timvandermeij
Copy link
Contributor

Thank you for working around this so we can at least upgrade again.

@Snuffleupagus Snuffleupagus deleted the non_webpack_require branch February 25, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants