[FxA] Indicate FxA sign in is needed to favorite shots

[jaredhirsch]

From FxA acceptance criteria:

It should indicate that favoriting shots requires sign in [note: this is currently demonstrated in the the spec by wiggling the sign-in button if the disabled favorite button is clicked]

[johngruen]

@punamdahiya please let @youwenliang and I know if you need more UX here.

[johngruen]

@youwenliang why don't we recycle the card we use to highlight the new annotations feature with something like "Sign in to save your favorite shots forever"

We could show it under the sign in button

[youwenliang]

I'm just wondering how users can trigger to show the promo panel, maybe when a user clicks the disabled favorite icon we can show the panel under the sign in button.

https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_fav_promo

[clouserw]

It looks possible to re-use the card there.

What happens if the Edit promo is shown (which uses the same card)

Also, the shot detail view layout you have above is a totally different UI than what we're building (eg. no button labels, buttons are below the header) -- is that intentional?

[punamdahiya]

we need to think through favorite icon shown when user is not authenticated e.g. What happens if a user SignIn -> Click on favorite icon and mark a shot favorite -> Sign out. In this case, should we show disabled favorite icon or hide it?

[youwenliang]

What I have in mind is like this:
If a user is not SignIn, they can see the disabled favorite icon, if they click the icon, the Fav Shot promo will display as shown in my comment above. If the Edit promo is already there, then the Edit promo should be dismissed and show the Fav Shot promo instead.
(I think the Fav Shot promo should also popup automatically if the users have seen the disabled fav icon several times already but haven't clicked it yet)

If a user SignIn -> click on fav icon -> sign out, the favorite icon should be "favorited" but disabled (40% opacity), just like what Will mentioned here: #4791 (comment)

[chenba]

A couple notes and a question for @johngruen and @youwenliang (cc @punamdahiya)

The placement of the favorite shot promo is currently a mixture of the editor promo and the mock-up from #4878 (comment). The editor promo is placed directly below the button. The favorite shot promo will be displayed below the sign in button but not tucked into a corner. It looks liek this:

Let me know if you want change the placement of either promo cards.

Should we still show the promo if the shot is already a favorite but the owner's been signed out?

I think the Fav Shot promo should also popup automatically if the users have seen the disabled fav icon several times already but haven't clicked it yet

If we are going to do this, I think we should create a new bug for it so we can work out the details there.

[youwenliang]

A couple notes and a question for @johngruen and @youwenliang (cc @punamdahiya)

The placement of the favorite shot promo is currently a mixture of the editor promo and the mock-up from #4878 (comment). The editor promo is placed directly below the button. The favorite shot promo will be displayed below the sign in button but not tucked into a corner. It looks liek this:

Let me know if you want change the placement of either promo cards.

Should we still show the promo if the shot is already a favorite but the owner's been signed out?

I think the Fav promo should only get triggered by someone who hasn't signed in before and clicks the disabled favorite icon.

I think the Fav Shot promo should also popup automatically if the users have seen the disabled fav icon several times already but haven't clicked it yet

If we are going to do this, I think we should create a new bug for it so we can work out the details there.

Sure, I'll work on this.

[youwenliang]

By the way I updated the promo panel design based on the discussion on Slack
-> https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_fav_promo/

[chenba]

I think the Fav promo should only get triggered by someone who hasn't signed in before and clicks the disabled favorite icon.

This make sense, but currently we don't track that. I can add a local (profile) level flag to check if the user ever signed in. @johngruen What say you?

[chenba]

I noticed that #4684 (PR #4910) is promoting favorite shots. I don't think we need this if we have the banner already.

[chenba]

John said we can close this without merging.