[FxA] Update Favorite button on shot page

[johngruen]

This is under-defined in the spec on both the shot page and the my shots page. We need a better overall interaction pattern to indicate favorite-ing shots.

[youwenliang]

Some quick ideas here:

[johngruen]

Looks good to me!

[youwenliang]

Measurements: https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA-4791/

[johngruen]

@youwenliang when you add assets can you unassign yourself and remove needs UX label

[clouserw]

If a shot has been favorited and the user signs out on the Shot View:

• The shot is shown as favorited, but greyed out/disabled

[punamdahiya]

Thanks Wil. You did it right, I should have left this comment here #4878 (comment)

[youwenliang]

@johngruen @punamdahiya
I put all the toolbar icons here: (I made small adjustments to the stroke weight for some of the icons so that they look consistent)
https://github.com/mozilla/testpilot-assets/tree/master/Firefox_Screenshots/00_Assets/Updated_Icons

[punamdahiya]

@youwenliang @johngruen Updated specs for 4791 shows disable Favorite icon on MyShots page. I propose on my shots page we keep favorite icon hidden as proposed here for reasons below
a) we should encourage user to sign in to see favorite shots.
b) Favorite icon on my shots is not clickable and could be confusing for users to show it enabled and not clickable even after SignIn

[youwenliang]

@youwenliang @johngruen Updated specs for 4791 shows disable Favorite icon on MyShots page. I propose on my shots page we keep favorite icon hidden as proposed here for reasons below
a) we should encourage user to sign in to see favorite shots.
b) Favorite icon on my shots is not clickable and could be confusing for users to show it enabled and not clickable even after SignIn

@punamdahiya Just a quick thought, is it possible to make the fav icon in MyShots page clickable? This way I think showing the disabled favorite icon after signed out makes more sense.

[punamdahiya]

Landed fix of this issue as per specs here #4791 (comment)

@youwenliang I have opened #4923 to discuss and implement favorite icon disabled state when user signin on shot page -> favorite -> signout -> Go To My shots