This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #4791 - Update Favorite button on MyShots Page #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punamdahiya
changed the title
flodolo
approved these changes
Sep 19, 2018
chenba
reviewed
Sep 19, 2018
static/img/icon-heart.svg
Outdated
| </g> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
Need to run the new svgs through svgo.
|
The button text color on My Shots need to be updated. And according to #4791 (comment) the icons have been updated, so we should pull those in. |
chenba
suggested changes
Sep 19, 2018
punamdahiya
force-pushed
the
4791_favorite_button
branch
from
79cf0e8 to
7f36161
Compare
punamdahiya
changed the title
|
@chenba PR is updated with new UX for favorite icon on my shots and shot page. Please review. Thanks! |
chenba
reviewed
Sep 19, 2018
server/src/pages/shot/view.js
Outdated
|
|
||
| favoriteShotButton = <div className="favorite-shot-button"><Localized id="shotPagefavoriteButton"> | ||
| <button className={`nav-button ${shouldShow} `} onClick={this.onClickFavorite.bind(this)}> | ||
| <button className={`nav-button ${shouldDisable} `} onClick={this.onClickFavorite.bind(this)}> |
There was a problem hiding this comment.
This should use the disabled attribute, not a class.
chenba
suggested changes
Sep 19, 2018
punamdahiya
force-pushed
the
4791_favorite_button
branch
from
7f36161 to
91dba74
Compare
|
PR updated with feedback, thanks |
chenba
approved these changes
Sep 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.