-
Notifications
You must be signed in to change notification settings - Fork 128
[FxA] Implement common marketing view (also in header) #4684
Comments
I tried a different color for the banner here (because the blue background and white text is not that readable and reminds me of Windows blue screen...) https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_Banner |
@punamdahiya I think this spec works... seems simple enough to just wrap the text? |
Looks good, assigning it to myself |
Few clarifications as per initial specs
Display of banner should be configurable via variable enableUpsellBanner |
|
@johngruen In initial specs Advertising banner with string as ‘Screenshots made simple. Take, save, and share screenshots without leaving Firefox. Get Firefox now.’ is only shown for non-owners and non-firefox users. This will replace existing message we show on shot page to non-firefox users. Is that correct? |
@youwenliang PR uses https://github.com/mozilla-services/screenshots/blob/master/static/img/landing-small-firefox-logo%402x.png as logo in banner which is 114 x 118, it will be good to get exact size asset. Thanks |
@punamdahiya |
Looking at the new spec, there's a common component used as an advertising banner across all pages. In some cases it has a little 🥕 pointing to the sign in button.
Refer to Shot View, My Shots and Home Page specs
It should accept arbitrary text and inline elements as children.
The text was updated successfully, but these errors were encountered: