Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Implement common marketing view (also in header) #4684

Closed
johngruen opened this issue Jul 20, 2018 · 8 comments
Closed

[FxA] Implement common marketing view (also in header) #4684

johngruen opened this issue Jul 20, 2018 · 8 comments
Assignees

Comments

@johngruen
Copy link
Contributor

johngruen commented Jul 20, 2018

Looking at the new spec, there's a common component used as an advertising banner across all pages. In some cases it has a little 🥕 pointing to the sign in button.

Refer to Shot View, My Shots and Home Page specs

It should accept arbitrary text and inline elements as children.

@ianb ianb added this to the Sprint 18 (63-2) milestone Jul 23, 2018
@jaredhirsch jaredhirsch changed the title [FxA] Implement common marketing view [FxA] Implement common marketing view (also in header) Jul 26, 2018
@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 19 (63-3) Aug 2, 2018
@youwenliang
Copy link
Contributor

youwenliang commented Sep 13, 2018

I tried a different color for the banner here (because the blue background and white text is not that readable and reminds me of Windows blue screen...)

image

https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_Banner

@johngruen
Copy link
Contributor Author

@punamdahiya I think this spec works... seems simple enough to just wrap the text?

@punamdahiya
Copy link
Contributor

Looks good, assigning it to myself

@punamdahiya punamdahiya self-assigned this Sep 13, 2018
@punamdahiya
Copy link
Contributor

Few clarifications as per initial specs

  • Advertising banner will be always visible for owners on shot page, myshots and homepage in non authenticated state, with strings as ‘Sign in or sign up to sync shots across devices, save your favorite shots forever.’ ( Final string TBD)
  • Advertising banner will be always visible on for non-owners on shot page with string as ‘Screenshots made simple. Take, save, and share screenshots without leaving Firefox.   Get Firefox now.’ ( Final string TBD)

Display of banner should be configurable via variable enableUpsellBanner

@punamdahiya
Copy link
Contributor

https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_Banner
@youwenliang Can you please provide firefox icon svg file used in banner. Thanks!

@punamdahiya
Copy link
Contributor

@johngruen In initial specs Advertising banner with string as ‘Screenshots made simple. Take, save, and share screenshots without leaving Firefox. Get Firefox now.’ is only shown for non-owners and non-firefox users. This will replace existing message we show on shot page to non-firefox users. Is that correct?

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 14, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 17, 2018
@punamdahiya
Copy link
Contributor

punamdahiya commented Sep 17, 2018

@youwenliang PR uses https://github.com/mozilla-services/screenshots/blob/master/static/img/landing-small-firefox-logo%402x.png as logo in banner which is 114 x 118, it will be good to get exact size asset. Thanks

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 18, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 18, 2018
@youwenliang
Copy link
Contributor

punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 19, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 19, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 19, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants