Remove product name from strings

[joeyg]

Fixes #991

[Pike]

FYI, we've stripped and fixed the Lockbox on our side in mozilla-l10n/lockwiseios-l10n@b8c623c for now.

[sashei]

I think we need to fix the FaceID usage description as well.

[devinreams]

The resulting output of the export scripts is shown here:
mozilla-l10n/lockwiseios-l10n#4

Any other changes need up here or downstream?

[sashei]

lgtm!

[Pike]

I've left some a comment on the import PR at mozilla-l10n/lockwiseios-l10n#4 (review).

In particular, there's still some "Lockbox" literal being imported back, which we'd like to get fixed still.

[Pike]

Denoting the change request

[devinreams]

Note to future self: where is the CFBundleName coming from? I can't tell how those strings get interpolated..

[Pike]

Note to future self: where is the CFBundleName coming from? I can't tell how those strings get interpolated..

lockwise-ios/lockbox-ios/Common/Resources/Info.plist

Lines 15 to 16 in e218836

	<key>CFBundleName</key>
	<string>$(PRODUCT_NAME)</string>

I think

[devinreams]

Results of latest export based on this branch is up here (no more Lockbox!):
mozilla-l10n/lockwiseios-l10n#5

[devinreams]

Oh I got aggressive and need to not rename the app quite so much.

[Pike]

I looked at the exported l10n strings, and they look OK, but the path change around Strings/en.lproj surprise me.

I can't pin them down to anything in this patch, though, did something else change?

[devinreams]

I can't pin them down to anything in this patch, though, did something else change?

Thanks @Pike.

I think it would have to be when we removed and then re-added (to clean out duplicate file inclusions) in Xcode here: #1011

[Pike]

sgtm