Skip to content
This repository was archived by the owner on Dec 14, 2021. It is now read-only.

Fix remaining Lockbox strings #991

Closed
Pike opened this issue May 17, 2019 · 1 comment · Fixed by #992
Closed

Fix remaining Lockbox strings #991

Pike opened this issue May 17, 2019 · 1 comment · Fixed by #992
Assignees
@devinreams
Labels
blocks-l10n Issues that block exposing new string exports for localization feature-localization task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Milestone
1.6.1 - Security ...

Comments

@Pike
Copy link
Contributor

Pike commented May 17, 2019

While setting up Lockwise iOS for localization, we found a few remaining occurrences of "Lockbox", some in UI, some in a11y, some in comments.

It'd be nice if we could get a fix for those before we expose strings for real.

You can search https://github.com/mozilla-l10n/lockwiseios-l10n/blob/5d9ab487f805536ebe9d9fd003ce783009a103c0/templates/lockwise-ios.xliff for examples.

lockwise-ios/CredentialProvider/Storyboard/Base.lproj/CredentialWelcome.storyboard

Line 46 in e64edee

<accessibility key="accessibilityConfiguration" label="Firefox Lockbox">
shows that this is at least in spots still happening.

I invented the "blocks-l10n" label for issues like this.

CC @Delphine @devinreams
@Pike Pike added the blocks-l10n Issues that block exposing new string exports for localization label May 17, 2019
@devinreams
Copy link
Contributor

@sashei @sandysage can we please promote these changes into the current sprint that’s being planned/started today?

@joeyg joeyg mentioned this issue May 17, 2019
Merged
@devinreams devinreams self-assigned this May 22, 2019
@devinreams devinreams added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label May 23, 2019
@devinreams devinreams removed this from the iOS 1.6.0 - Rebrand and Localize milestone May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devinreams devinreams

Labels
blocks-l10n Issues that block exposing new string exports for localization feature-localization task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Projects
None yet
Milestone
1.6.1 - Security and Stability
Development

Successfully merging a pull request may close this issue.

Remove product name from strings mozilla-lockwise/lockwise-ios
2 participants
@Pike @devinreams